[#17193] - [4.0] Change vote option to switcher
- Fixed in Code Base
- 20 Jul 2017
- Medium
- Build: 4.0-dev
- # 17193
- Diff
- brianteeman:show_hide
- Success hound No violations found. Woof! Details
- Pending continuous-integration/appveyor/pr Waiting for AppVeyor build to complete Details
- Pending continuous-integration/travis-ci/pr The Travis CI build is in progress Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
This PR changes the vote setting in the article options to the new switcher class for options
An added benefit it that before when the plugin was not enabled the select list was empty. Now if the plugin is not enabled there is nothing displayed in the values. NOTE if someone knows how to improve this perhaps by hiding the label as well that would be great
Before with plugin enabled
Before with plugin disabled
After with plugin enabled
After with plugin disabled
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
@franz-wohlkoenig as I wrote originally
NOTE if someone knows how to improve this perhaps by hiding the label as well that would be great
;)
äh*g that happens if test starts to quickly …
I'm actually at the point where I'd rather move the voting plugin logic in full into com_content and drop the plugin. With the addition of the filtering options for vote data in 3.7, there isn't a clean way now to fully separate the plugin and the component (#12331 for full context).
Agree. I want to say there's something in JForm that lets you conditionally hide fields based on another extension being installed/enabled, but I don't remember how that's triggered off hand.
PR welcome ;)
@brianteeman you also need to switch the field options around when you use the switcher. I add comments in there for you
| Labels |
Added:
?
|
||
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17193.
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-20 20:30:02 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on 34eb094
Shouldn't the 2 Labels be hidden if Plugin is disabled?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17193.