[#17184] - Remove the never working limitstart call
- Closed
- 25 Jul 2017
- Medium
- Build: staging
- # 17184
- Diff
- zero-24:removethelimitstart
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Pending continuous-integration/jenkins/pr-merge This commit is being built Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Remove the never working limitstart call. I did go back in the history and that not working call is included since the intial commit to GitHub:
https://github.com/joomla/joomla-cms/blame/56fbf2c55293b3188c7d85163dfcf91eac01741c/components/com_content/helpers/icon.php#L106-L110
Intial report by @moira-lachesis
Testing Instructions
Confirm that the print button in the frontend still works.
Expected result
The print button in the frontend still works.
Actual result
The print button in the frontend works but append a empty an unused &page=.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17184.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
| Labels |
Added:
?
|
||
| Category | Front End com_content | ⇒ | Front End com_content Installation Language & Strings Libraries |
You started the PR based on staging then changed the branch to 3.8. But your staging branch is a few commits ahead of the 3.8 branch (expected, the commits in this PR aren't merged to 3.8 yet). So it's fine for now, I just have to remember to merge staging to 3.8 before merging this PR.
Thans for checking!
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-25 23:04:27 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on d39631b
tested on a single and a multipage article and apart from the page= now being removed it all works the same
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17184.