? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
19 Jul 2017

Pull Request for Issue #17181

Summary of Changes

The get Module returns null in case that the module does not exists..

Testing Instructions

Steps to reproduce the issue

  • Do a fresh install from repo
  • Go to Global Settings
  • Enable Debugging
  • Save

Expected result

  • No warnings at all

Actual result

An error regarding this

image

Documentation Changes Required

none

Additional comments

@infograf768 is it possible that we have setup a multi language site but do not have a mod_multilangstatus module? This needs to be tested too than.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar zero-24 zero-24 - open - 19 Jul 2017
avatar zero-24 zero-24 - change - 19 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Jul 2017
Category Modules Administration
avatar zero-24 zero-24 - change - 19 Jul 2017
Title
Only try to load the module if we are in multilang mode
[4.0-dev] Only try to load the module if we are in multilang mode
avatar zero-24 zero-24 - edited - 19 Jul 2017
avatar zero-24 zero-24 - change - 19 Jul 2017
Title
Only try to load the module if we are in multilang mode
[4.0-dev] Only try to load the module if we are in multilang mode
avatar zero-24 zero-24 - change - 19 Jul 2017
The description was changed
avatar zero-24 zero-24 - edited - 19 Jul 2017
avatar brianteeman
brianteeman - comment - 19 Jul 2017

You do not need the module it is just helpful

avatar C-Lodder C-Lodder - test_item - 21 Jul 2017 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 21 Jul 2017

I have tested this item successfully on 65a5552


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17182.

avatar wilsonge
wilsonge - comment - 29 Jul 2017

@zero-24 this error will still exist in multilang mode I think? The problem is us using the variable name $module I think if we call $module a different variable name this gets fixed

avatar wilsonge
wilsonge - comment - 29 Jul 2017

OK on testing with a multilang site this works

avatar wilsonge wilsonge - change - 29 Jul 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-29 13:25:10
Closed_By wilsonge
avatar wilsonge wilsonge - close - 29 Jul 2017
avatar wilsonge wilsonge - merge - 29 Jul 2017

Add a Comment

Login with GitHub to post a comment