? ? Success

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
17 Jul 2017

Pull Request for Issue #17130

Summary of Changes

Just some tweaks to improve the styling to access user notes

@brianteeman The first item in the dropdown says "Show notes list for this user". The string seems a little long for my liking. Are you happy to change to just "Show notes list"?

avatar C-Lodder C-Lodder - open - 17 Jul 2017
avatar C-Lodder C-Lodder - change - 17 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2017
Category Administration com_users
avatar C-Lodder C-Lodder - change - 17 Jul 2017
Labels Added: ?
avatar brianteeman
brianteeman - comment - 17 Jul 2017

Much better - and yes that lang change is good to go for now

Although to be honest I am not sure why we have both the list and the popup

avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2017
Category Administration com_users Administration com_users Language & Strings
avatar brianteeman brianteeman - test_item - 17 Jul 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 17 Jul 2017

I have tested this item successfully on bdd18b8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17152.

avatar C-Lodder
C-Lodder - comment - 17 Jul 2017
avatar zero-24
zero-24 - comment - 17 Jul 2017
FILE: ...la/joomla-cms/administrator/components/com_users/helpers/html/users.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 104 | WARNING | Line exceeds 150 characters; contains 180 characters
--------------------------------------------------------------------------------

http://213.160.72.75/joomla/joomla-cms/6934 ;)

avatar C-Lodder C-Lodder - change - 17 Jul 2017
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 17 Jul 2017

@zero-24 oops, fixed

avatar zero-24
zero-24 - comment - 17 Jul 2017

?

avatar wilsonge wilsonge - change - 17 Jul 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-17 17:03:05
Closed_By wilsonge
avatar wilsonge wilsonge - close - 17 Jul 2017
avatar wilsonge wilsonge - merge - 17 Jul 2017

Add a Comment

Login with GitHub to post a comment