? Pending

User tests: Successful: Unsuccessful:

avatar fastslack
fastslack
17 Jul 2017

Summary of Changes

This PR pretend to replace old fields classes to namespaces

Testing Instructions

Install and run Joomla! normaly without issues in forms

Expected result

All work as usual

avatar fastslack fastslack - open - 17 Jul 2017
avatar fastslack fastslack - change - 17 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2017
Category Libraries
avatar fastslack fastslack - change - 17 Jul 2017
Title
Initial form fields namespaces
[3.8] Initial form fields namespaces
avatar fastslack fastslack - edited - 17 Jul 2017
avatar fastslack fastslack - change - 17 Jul 2017
The description was changed
avatar fastslack fastslack - edited - 17 Jul 2017
avatar fastslack fastslack - change - 17 Jul 2017
Labels Added: ?
avatar laoneo
laoneo - comment - 17 Jul 2017

According to the discussion in Krakow with @mbabker we can't namespace the fields in libraries/joomla in the 3 series, because of autoloading. So this pr should be targeted against the 4.0-dev branch.

avatar mbabker
mbabker - comment - 17 Jul 2017

The two in libraries/legacy are fine to do for 3.8. But the rest in libraries/joomla have to wait for 4.0 since the directory they are in now is not autoloaded and this move would make the classes autoloaded and we've already run into problems with duplicated classes from the core field offerings.

avatar fastslack fastslack - change - 17 Jul 2017
Title
[3.8] Initial form fields namespaces
[4.0] Initial form fields namespaces
avatar fastslack fastslack - edited - 17 Jul 2017
avatar fastslack
fastslack - comment - 17 Jul 2017

@laoneo @mbabker Im targeting this to 4.0 and create a new PR with the legacy fields

avatar fastslack
fastslack - comment - 17 Jul 2017

@laoneo @mbabker Should I close this and made 2 PR again?

avatar laoneo
laoneo - comment - 17 Jul 2017

You can change the base branch of the pr. What you need to do then is to merge it with the 4.0-dev branch.

avatar fastslack
fastslack - comment - 18 Jul 2017

Hmm better to close this and open 2 PR separately

avatar fastslack fastslack - change - 18 Jul 2017
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2017-07-18 03:20:49
Closed_By fastslack
avatar fastslack fastslack - close - 18 Jul 2017
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jul 2017
Category Libraries Unit Tests Administration com_admin SQL Postgresql MS SQL com_banners com_categories com_config com_contact com_content com_fields com_finder com_joomlaupdate com_menus

Add a Comment

Login with GitHub to post a comment