Feeling Lucky
?
[#17145] - Fixed PSR-4 loader implementation. Issue #17098.
- Closed
- 5 Nov 2017
- Medium
- Build: staging
- # 17145
- Diff
- berserkerx:staging
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
If class name starts with the same token, as namespace prefix or contains namespace prefix, the class was not loaded correctly.
Pull Request for Issue #17098 .
Summary of Changes
Added check for '/' after namespace prefix, replaced 'str_replace' with 'substr' to ensure, that prefix is only removed from the start of class path.
Testing Instructions
Create libraries/app/vendor/B/src/B.php class with anyMethod method.
JLoader::registerNamespace('B', JPATH_SITE . '/libraries/app/vendor/B/src', $reset = true, $prepend = false, $type = 'psr4');
\B\B::anyMethod();
Expected result
Autoloading \B\B class and calling anyMethod.
Actual result
Class not found.
Votes
# of Users Experiencing Issue
1/1
Average Importance Score
5.00
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-07 15:10:02 |
| Closed_By | ⇒ | berserkerx |
| Status | Closed | ⇒ | Pending |
franz-wohlkoenig
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 2017-09-07 15:10:02 | ⇒ | 2017-11-05 09:36:13 |
| Closed_By | berserkerx | ⇒ | franz-wohlkoenig |
joomla-cms-bot
- comment
- 5 Nov 2017
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/17145
What's the reason of failure?
Branch indexing
Connecting to https://api.github.com using joomla-release/******
Loading trusted files from base branch staging at 48f58a6 rather than 81e8f47
Obtained Jenkinsfile from 48f58a6
[Pipeline] node
Still waiting to schedule task
Warte auf den nächsten freien Build-Prozessor
[Pipeline] // node
[Pipeline] End of Pipeline
GitHub has been notified of this commit’s build result
ERROR: Queue task was cancelled
Finished: FAILURE
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17145.