List for UA's to consider testing for

• CriOS
  • Mozilla/5.0 (iPad; CPU OS 10_3_2 like Mac OS X) AppleWebKit/603.1.30 (KHTML, like Gecko) CriOS/59.0.3071.102 Mobile/14F89 Safari/602.1
• Windows RSS IE
  • Windows-RSS-Platform/2.0 (IE 11.0; Windows NT 6.1)
• IE 11 where trident engine is 7 but IE is 11
  • Mozilla/5.0 (Windows NT 6.3; Trident/7.0; rv:11.0) like Gecko
• IE 11 where trident engine is 7 but IE is 11 and there are things like compatibility markers before the version
  • Mozilla/5.0 (Windows NT 6.3; Trident/7.0; .NET4.0E; .NET4.0C; rv:11.0) like Gecko
• Firefox 53
  • Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0
• Firefox other (typically developer preview releases)
  • Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.9) Gecko/20071113 BonEcho/2.0.0.9
  • Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.8) Gecko/2009033017 GranParadiso/3.0.8
  • Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2) Gecko/20100411 Lorentz/3.6.3 GTB7.0
  • Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a4pre) Gecko/20100402 Minefield/3.7a4pre
  • Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2a1) Gecko/20090806 Namoroka/3.6a1
  • Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090109 Shiretoko/3.1b3pre
  • Mozilla/5.0 (compatible; Windows NT 5.1; en-US; rv:2.0;) Gecko/20110318 (Treco, Sub Engine) Fireweb Navigator/3.0
  • Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.5) Gecko/20031007 Firebird/0.7
• Google bot
  • Mozilla/5.0 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)
• bing bot
  • Mozilla/5.0 (compatible; bingbot/2.0; +http://www.bing.com/bingbot.htm)
• curl
  • curl/7.35.0
• Wget
  • Wget/1.15 (linux-gnu)
• FeedBurner
  • FeedBurner/1.0 (http://www.FeedBurner.com)

Here are links to get common user agents to test with

• http://www.networkinghowtos.com/howto/common-user-agent-list/
• https://udger.com/resources/ua-list

@mbabker I've pinged you and @wilsonge for comments in #17051 (comment), which is already RTC. Apart from the "missing" test, why the new PR`?

I started only by writing the unit tests. When I copied over the Mozilla user agents from the web client class' test case, I found those were failing to detect the correct version and added a fix for that too. Can't say I remembered that PR being open, either way it doesn't matter what order things get merged in but the added unit test cases are required.

The problem with Firefox not being detected correctly was not only because of a missing else / if, but the regular expression for "mozilla" browsers being: preg_match('|Mozilla/([0-9.]+)|', $this->agent, $version) which is the case for almost any UA, since they start with Mozilla/X.X.

I've also looked into some alternative Mozilla ~ Firefox based browsers which all(?) have their own UA and would now be detected as "mozilla". Therefore my question #17051.

For this to work in the future, we either have to "remove" the Mozilla check, sort of what I did. or put it at the very end of that list, right?

I have no idea honestly, browser detection isn't something I do normally. I just did what looked to be a valid fix for the issue I ran into while importing tests. I do know without a change in JBrowser we are reporting incorrect data (something the web client class handles better right now) in that the browser version number is wrong. So clearly we need to do something, I'll leave the specifics of that to people more interested or knowledged in the area, we just need to get tests for the JBrowser class merged in at some point because right now the lines that are covered are because JHtml uses it.

This is updated now to only add the unit test cases, the browser detection can be sorted in the other PR.

Merged on review