?
avatar VampiRUS
VampiRUS
14 Jul 2017

Steps to reproduce the issue

Component has submenu item with filter option:

<submenu>
	<menu link="option=com_plugins&amp;view=plugins&amp;filter[search]=search"
		view="plugins" img="class:plugin" alt="Plugins">com_component_plugins</menu>
</submenu>

Expected result

Actual result

Error notice in admin panel:
Notice: Array to string conversion in /var/www/js/administrator/modules/mod_menu/menu.php on line 613

System information (as much as possible)

Joomla 3.7.3

Additional comments

avatar VampiRUS VampiRUS - open - 14 Jul 2017
avatar joomla-cms-bot joomla-cms-bot - change - 14 Jul 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 14 Jul 2017
avatar VampiRUS VampiRUS - change - 14 Jul 2017
The description was changed
avatar VampiRUS VampiRUS - edited - 14 Jul 2017
avatar VampiRUS VampiRUS - change - 14 Jul 2017
The description was changed
avatar VampiRUS VampiRUS - edited - 14 Jul 2017
avatar VampiRUS VampiRUS - change - 14 Jul 2017
The description was changed
avatar VampiRUS VampiRUS - edited - 14 Jul 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 14 Jul 2017
Category com_menus
avatar zero-24
zero-24 - comment - 14 Jul 2017

Please tell us the exact PHP Version. As $parts should be an array and impode is constructed to move arrays to strings. I'm a bit confused.

avatar VampiRUS
VampiRUS - comment - 14 Jul 2017

php 5.5.9
if $link = "index.php?option=com_plugins&view=plugins&filter[search]=search";
$uri->getQuery(true);
will return

array (
   'option' => 'com_plugins',
   'view' => 'plugins',
   'filter' =>
   array (
   'search' => 'search',
   ),
   )
avatar eshiol
eshiol - comment - 14 Jul 2017

The issue is in administrator/modules/mod_menu/menu.php on line 610

				$parts[] = str_replace(array('.', '_'), '-', $value);

Try to replace it with

				if (!is_array($value))
				{
					$parts[] = str_replace(array('.', '_'), '-', $value);
				}
				else
				{
					foreach ($value as $k => $v)
					{
						$parts[] = $k.'-'.str_replace(array('.', '_'), '-', $v);
					}
				}
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Jul 2017
Status New Information Required
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Aug 2017

@VampiRUS have you tried above Suggestion?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17128.

avatar VampiRUS
VampiRUS - comment - 30 Aug 2017

@franz-wohlkoenig yes it helps


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17128.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Aug 2017

@VampiRUS as Issue is resolved can you please close the Issue?

avatar VampiRUS
VampiRUS - comment - 30 Aug 2017

@franz-wohlkoenig this is issue in joomla code, i think it must be fixed there.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Sep 2017

@maintainers any Opinion?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17128.

avatar zero-24
zero-24 - comment - 19 Sep 2017

@franz-wohlkoenig just FYI you can't tag @maintainers you just tag this org: https://github.com/maintainers ;)

Regarding the topic what about doing the suggested code changes as PR so we can test and merge the fix?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 19 Sep 2017

@zero-24 will try to remember :-)

avatar mbabker
mbabker - comment - 19 Sep 2017

I don't remember what the permissions are on GitHub but you can try pinging @joomla/cms-maintainers

avatar zero-24
zero-24 - comment - 19 Sep 2017

IMO you need to be part of that team or owner to be allowed to ping the team ;)

avatar mbabker
mbabker - comment - 19 Sep 2017

I don't remember what the permissions are on who can ping teams or who is in what team off the top of my head. If the feature works for him then cool, if not, well, blame GitHub ?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Oct 2017
avatar infograf768
infograf768 - comment - 22 Oct 2017
avatar izharaazmi
izharaazmi - comment - 23 Oct 2017

This issue is out of context since the merge of #16451. The changes can be see here

I have also verified the new code and I can confirm that this was not carried over. Hence IMHO, this can be safely closed. Thanks.

avatar franz-wohlkoenig franz-wohlkoenig - change - 23 Oct 2017
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2017-10-23 06:44:21
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 23 Oct 2017
Closed_Date 2017-10-23 06:44:21 2017-10-23 06:44:22
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 23 Oct 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Oct 2017

closed as stated above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17128.

avatar joomla-cms-bot
joomla-cms-bot - comment - 23 Oct 2017

Add a Comment

Login with GitHub to post a comment