?
avatar pascal-910
pascal-910
13 Jul 2017

Steps to reproduce the issue

Fresh install of joomla 3.7.3

  1. Add a new Contact
    a. linked to Super user
  2. Add a new Menu item of type „Single contact“ and select added contact from step 1
  3. Extensions – Plugins
    a. Enable „Captcha – ReCaptcha“ Plugin
    b. Go to Plugin configuration and enter dummy string into „Site key“ and „Secret Key“ (for ex. „xxx“)
  4. Global Configuration – Site – Default Captcha: Set to „ReCaptcha“
  5. Go to front-end and select menu created in step 2)
    Then select „Contact form“ and enter something into “Name”, “Email”, “Subject” and “Message” field. Then press “Send Email”

Expected result

Postback, then message box that captcha wasn't set and still filled Textboxes

Actual result

Postback with messagebox, but all textboxes are empty so user has to enter again everything

System information (as much as possible)

Problem didn't occur before 3.7.3
PHP 5.4.16
Win7 Business Edition SP1
Apache 2.4.4.
Mysql 5.0.10

Additional comments

Hint to solution/reason:

I don’t know what’s the line for but in file “components\com_contact\views\contact\view.html.php” line 75 the contact data will be overwritten with category id. If this line is commented out it works. You can enter something in contact form, if you don’t enter captcha data and submit no data will be lost in textboxes and user don’t need to enter again.

$app->setUserState('com_contact.contact.data', array('catid' => $item->catid));

Votes

# of Users Experiencing Issue
0/2
Average Importance Score
5.00

avatar pascal-910 pascal-910 - open - 13 Jul 2017
avatar joomla-cms-bot joomla-cms-bot - labeled - 13 Jul 2017
avatar pascal-910 pascal-910 - change - 13 Jul 2017
The description was changed
avatar pascal-910 pascal-910 - edited - 13 Jul 2017
avatar infograf768
infograf768 - comment - 14 Jul 2017

Please test #17122


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17126.
avatar funbugpiz
funbugpiz - comment - 18 Jul 2017

I use my own simple captcha plugin.
If I entered data in the contact form and do not fill in correctly the captcha field, all form data loses after a post.
Problem didn't occur certainly in J3.7.0.
#17122 test negative.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17126.
avatar funbugpiz
funbugpiz - comment - 18 Jul 2017

Additional comment:

See also: Additional comments pascal-910 (13 july)

If I delete the line 75: $app->setUserState('com_contact.contact.data', array('catid' => $item->catid));
No data in contact form data loses. That's OK.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17126.
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Jul 2017
Status New Discussion
avatar tonypartridge
tonypartridge - comment - 27 Jul 2017

You shouldn't delete the line but instead use a getfromstate request in there and if it doesn't exists it sets $itsm->catid

avatar funbugpiz
funbugpiz - comment - 27 Jul 2017

With var_dump($item) you can see that $item->catid is already loaded. So it exists.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17126.

avatar sandewt
sandewt - comment - 28 Aug 2017

Hi @tonypartridge,

Do you mean the following?

Change line 75 (..a\components\com_contact\views\contact\view.html.php))

$app->setUserState('com_contact.contact.data', array('catid' => $item->catid));

To

if (!isset($item->catid) || empty($item->catid))
{	
   $app->setUserState('com_contact.contact.data', array('catid' => $item->catid));
}

If I tested local, its works by the 'Single Contact' form + captcha enabled.

Gr.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17126.

avatar tonypartridge
tonypartridge - comment - 28 Aug 2017

That looks good to me Gr, can you do a pull request?

avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Aug 2017
Status Discussion Information Required
avatar sandewt
sandewt - comment - 28 Aug 2017

I have made my first pull request #17743.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17126.

avatar joomla-cms-bot joomla-cms-bot - close - 28 Aug 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Aug 2017
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2017-08-28 14:25:41
Closed_By franz-wohlkoenig
avatar joomla-cms-bot
joomla-cms-bot - comment - 28 Aug 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Aug 2017

closed as having Pull Request #17743


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17126.

avatar sandewt
sandewt - comment - 16 Dec 2017

Hi @franz-wohlkoenig, Pull Request #17743 is still open for testing.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Dec 2017

have called 2 former Testers for retest.

Add a Comment

Login with GitHub to post a comment