Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#17124] - [Regression] Keep B/C in the redirect plugin

? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
13 Jul 2017

Summary of Changes

If you have set up some urls with mixed upper and lower case in the redirect component before this patch they did not got redirected anymore.

Testing Instructions

  • Set up a redirect with a uppercase char in the URL.
  • call the exact URL with the uppercase
  • no redirect
  • apply this patch
  • it is working again

Expected result

Old redirects still work

Actual result

Old redirects with uppercase chars are broken

Documentation Changes Required

None

avatar zero-24 zero-24 - open - 13 Jul 2017
avatar zero-24 zero-24 - change - 13 Jul 2017
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jul 2017
Category ⇒ Front End Plugins
6edabc8 13 Jul 2017 avatar zero-24 drone
avatar zero-24 zero-24 - change - 13 Jul 2017
Labels Added: ?
avatar wilsonge
wilsonge - comment - 13 Jul 2017

that patch

Which patch xD

avatar zero-24
zero-24 - comment - 13 Jul 2017

Which patch xD

that => this

So without this patch here they did not got redirected anymore. I'm going to fix that ;)

avatar zero-24 zero-24 - change - 13 Jul 2017
The description was changed
avatar zero-24 zero-24 - edited - 13 Jul 2017
avatar zero-24
zero-24 - comment - 13 Jul 2017

This patch here: #13853 introduced the issue by forcing it to be lowercase but not respecting the mixed ones in the database. ;)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 14 Jul 2017

@zero-24 i setup following redirect which works without PR so i guess i didn't get Issue:
bildschirmfoto 2017-07-14 um 07 10 48

avatar infograf768
infograf768 - comment - 14 Jul 2017

hmm, This here works without patch:

screen shot 2017-07-14 at 09 07 38

avatar zero-24
zero-24 - comment - 14 Jul 2017

The problem is that they does not find the old URL.

Please set the old URL withe upper cases and a different URL with lower cases. Please also make sure that the plugin is enabled.

avatar infograf768 infograf768 - test_item - 14 Jul 2017 - Not tested
avatar infograf768
infograf768 - comment - 14 Jul 2017

When the Expired URL contains a some Upper case, indeed this patch corrects the issue.
screen shot 2017-07-14 at 09 36 44

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17124.
avatar infograf768 infograf768 - test_item - 14 Jul 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 14 Jul 2017

I have tested this item ✅ successfully on 6edabc8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17124.

avatar zero-24
zero-24 - comment - 14 Jul 2017

When the Expired URL contains a some Upper case, indeed this patch corrects the issue.

Is'n this than a succesful test?

avatar zero-24
zero-24 - comment - 14 Jul 2017

Ah our messages crossed ;)

avatar matrikular matrikular - test_item - 17 Jul 2017 - Tested successfully
avatar matrikular
matrikular - comment - 17 Jul 2017

I have tested this item ✅ successfully on 031a3d8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17124.

avatar infograf768 infograf768 - test_item - 17 Jul 2017 - Tested successfully
avatar infograf768
infograf768 - comment - 17 Jul 2017

I have tested this item ✅ successfully on 031a3d8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17124.

avatar infograf768 infograf768 - change - 17 Jul 2017
Status Pending ⇒ Ready to Commit
avatar infograf768
infograf768 - comment - 17 Jul 2017

RTC, good for 3.7.4

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17124.

avatar rdeutz rdeutz - change - 17 Jul 2017
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-07-17 08:26:24
Closed_By ⇒ rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 17 Jul 2017
avatar rdeutz rdeutz - merge - 17 Jul 2017

Add a Comment

Login with GitHub to post a comment