[#17122] - REGRESSION: Profile form bug when registering Fix #17001
- Fixed in Code Base
- 17 Jul 2017
- Urgent
- Build: staging
- # 17122
- Diff
- bembelimen:patch-29
User tests: Successful: Unsuccessful:
Pull Request for Issue #17001 .
Summary of Changes
This patch makes sure, that forms are not created twice, because of the data loading parameter. See: #17001 and #17043 (comment)
Testing Instructions
#17001 (comment) This patch should fix this behavior
Expected result
Plugins work correctly
Trigger: @infograf768 @Spudley
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Priority | Medium | ⇒ | Urgent |
I have tested this item
Patch ok for me
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17122.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
RTC.
Please @rdeutz merge before RC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17122.
@nikosdion could you have a look at this, thanks!
This looks pretty safe and fixes a long-standing issue. Forms should be instantiated once per model.
As a further step to avoid similar regressions in the future I would recommend that the leadership documents the opaque $options array and links to the documentation from the docblock of the method.
If I were to be pedantic I'd say that ideally we should be passing immutable objects instantiated against final classes (therefore: with predefined properties and with data that can't change) to make the internal API self-documenting and consistent. But since this course of action would be breaking b/c, in a package marked legacy nonetheless, I think we can safely assume this isn't happening in the near future. So at least documenting opaque parameters would be a good step towards avoiding similar regressions in the future.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-17 11:40:27 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Thanks for all worked and commented on this :-)
I have tested this item✅ successfully on 2c3d04a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17122.