[#17113] - Text Filters layout
- Fixed in Code Base
- 25 Jul 2017
- Medium
- Build: staging
- Easy Test
- # 17113
- Diff
- brianteeman:filters
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending continuous-integration/jenkins/pr-merge This commit is being built Details
User tests: Successful: Unsuccessful:
At some point in the past (3.6.5?) when layouts were added the design of the global configuration text filters was changed and it looks odd
This PR adds a new layout just for text filters without the big empty space
Pull Request for Issue #15423
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config Layout |
| Easy | No | ⇒ | Yes |
Why have every PHP line wrapped in ?PHP
I just took the existing layout and removed the things we don't need here.
Why have every PHP line wrapped in ?PHP
because it is a layout file ;) And this is supposed to have that ;)
Where is this file so i can correct it there too :)
Joomla.contemt.options_default
@brianteeman check out the section on layouts: https://developer.joomla.org/coding-standards/php-code.html
I was only working from an existing layout :(
I will update it as requested
| Milestone |
Added: |
||
can this be retested please
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17113.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17113.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-25 23:24:09 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Thanks
I have tested this item✅ successfully on 1ee6f69
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17113.