?
avatar brianteeman
brianteeman
13 Jul 2017

the batch modal in com_users still has code testing for mootools

avatar brianteeman brianteeman - open - 13 Jul 2017
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jul 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 13 Jul 2017
avatar dgt41
dgt41 - comment - 13 Jul 2017

@brianteeman do you mean this part:

 $isMoo = $input->getInt('ismoo', 1);
  
  if ($isMoo)
  {
      $onClick = "window.parent.jSelectUser(this);window.parent.jQuery('.modal.in').modal('hide');";
  }
avatar franz-wohlkoenig franz-wohlkoenig - change - 13 Jul 2017
Category com_users
avatar franz-wohlkoenig franz-wohlkoenig - change - 13 Jul 2017
Status New Discussion
avatar C-Lodder
C-Lodder - comment - 19 Jul 2017

I can submit the PR to remove the Mootools check, but there still 1 issue.

New Article >> Publishing Options >> Created By (try selecting a user)

Getting 2 console log errors. 1 being from multiselect.js which I don't seem to understand why it's there, as it's used for the checkboxes on list views.

avatar C-Lodder
C-Lodder - comment - 30 Aug 2017

This PR removes the Mootools reference right?

#17763

avatar franz-wohlkoenig franz-wohlkoenig - change - 31 Aug 2017
Status Discussion Information Required
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Sep 2017

@brianteeman i guess @C-Lodder ask you.

avatar brianteeman
brianteeman - comment - 17 Sep 2017

Correct it willbe fixed if that gets merged

avatar brianteeman brianteeman - change - 17 Sep 2017
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2017-09-17 11:12:42
Closed_By brianteeman
avatar brianteeman brianteeman - close - 17 Sep 2017

Add a Comment

Login with GitHub to post a comment