? Pending

User tests: Successful: Unsuccessful:

avatar leoalv
leoalv
13 Jul 2017

Validate attribute for on label tag

Pull Request for Issue # .

Summary of Changes

Removed the single quote that generated an incorrect value for the FOR attribute. Now FOR value is same to ID of SELECT tag.

Testing Instructions

Validate your code with W3C

Expected result

Valid code

Actual result

No valid code

Documentation Changes Required

Not necessary

avatar leoalv leoalv - open - 13 Jul 2017
avatar leoalv leoalv - change - 13 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jul 2017
Category Front End Plugins
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Jul 2017

can you please provide Summary of Changes, Testing Instructions, ... so People know how to test, if its a Code Review, ...?

avatar leoalv leoalv - change - 13 Jul 2017
The description was changed
avatar leoalv leoalv - edited - 13 Jul 2017
avatar leoalv
leoalv - comment - 13 Jul 2017

Updated summary and instructions

avatar zero-24
zero-24 - comment - 13 Jul 2017

Merging on review as this was clearly a mistake at the time it was moved here: #11300

Thanks @leoalv ?

avatar zero-24 zero-24 - change - 13 Jul 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-13 07:33:18
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 13 Jul 2017
avatar zero-24 zero-24 - merge - 13 Jul 2017

Add a Comment

Login with GitHub to post a comment