I have tested this item ✅ successfully on f481f3e

Looks great#

off the top of my head you need to check to make sure everything is ok when an item is checked out and also if there is an item that you dont have permission to edit.

aria-hidden="true" added to icon.

The icon now also only shows when the item is checked in

Thanks - seems great - will test in depth later today

I am wondering if we can improve this for accessibility

Currently it is two links and says "edit" "edit"

It would be much better if it was just one link that says "edit title"

I am assuming you will do another PR to remove the edit button from all the other components?

Technically it's still one link as both the icon and title with within the same <a> tag. I just added a right margin to the icon so that when you ho er over the title, the underline doesnt appear yhrougj the gap.

I'll do it all as 1 PR but want to make sure people are happy with the initial concept first

Quite right i should have looked atthe code not just the output.

What you could do though is to change the line to something like

<a class="hasTooltip" href="<?php echo JRoute::_('index.php?option=com_content&task=article.edit&id=' . $item->id); ?>" title="<?php echo JText::_('JACTION_EDIT'); ?> <?php echo $this->escape(addslashes($item->title)); ?>">

And then the title will be more meaningful as "Edit Article Name"

@brianteeman updated

I have tested this item ✅ successfully on 76fed33

I have tested this item ✅ successfully on 76fed33

What you could do though is to change the line to something like

Not with tooltips. Links are one of the fundamental concepts of the web, if ppl don't know that clicking on a link will take them to another page (in this case the edit view) we can't and shouldn't try to teach them in the backend about it!

It's an a11y thing where you are explicitly saying what they will edit. Otherwise you have a hundred links on the page with the same title

Then let's prepend the title with something like Edit: Title of the article. No tooltips, no aria-whatever

Isn't that what the icon is communicating to visually capable users? Or is it better to have a list of 20 links that reads Edit: Foo?

@dgt41 that's exactly what the code I proposed does. Doesn't it?

@mbabker @brianteeman the icon itself is not ok, we need a fallback for screenreaders/ppl visually impaired

Unless I got !y code wrong that's all done

Unless I misread something the tooltip (title attribute) covers things fine for people using screenreaders or other assistive software. The only thing that's not good is for people not using those and seeing an icon, but repeating the word "Edit" 20 times doesn't seem any better.

Can someone remove RTC please, as I need to do the rest of the components and this title thing needs to be decided on

For reference this is why you must have a title link for accessibility
https://www.w3.org/TR/WCAG20-TECHS/H33.html

And why links must have unique titles
http://webaim.org/techniques/hypertext/#screen_readers
Links should make sense out of context. Phrases such as "click here," "more," "click for details," and so on are ambiguous when read out of context

@brianteeman point is about class="hasTooltip", not the title

@dgt41 class="hasTooltip" isn't a problem. We're already in the process of removing tooltips.

The PR adds an edit icon to list item titles and removes the edit icon from the toolbar, nothing else. The tooltip that you see is was already there

I'm going to carry on with this PR to remove the edit button from the remaining components. If you guys want to discuss the title any more, you can submit an issue and new PR after

Ok, believe they're all done now

@wilsonge @brianteeman all happy with this?

yes