? ? ? Pending

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
12 Jul 2017

Summary of Changes

Runs composer update for 3.8. Operations run (this includes packages used solely in our testing environments as well as code shipped with production releases):

Package operations: 0 installs, 19 updates, 0 removals
  - Updating symfony/polyfill-php55 (v1.3.0 => v1.4.0): Loading from cache
  - Updating joomla/filter (1.3.2 => 1.3.3): Loading from cache
  - Updating joomla/application (1.7.0 => 1.8.1): Loading from cache
  - Updating paragonie/sodium_compat (v1.0.1 => v1.1.0): Loading from cache
  - Updating phpmailer/phpmailer (v5.2.23 => v5.2.24): Downloading (100%)         
  - Updating symfony/polyfill-util (v1.3.0 => v1.4.0): Loading from cache
  - Updating symfony/polyfill-php56 (v1.3.0 => v1.4.0): Loading from cache
  - Updating symfony/yaml (v2.8.20 => v2.8.26): Loading from cache
  - Updating phpdocumentor/reflection-docblock (2.0.4 => 2.0.5): Loading from cache
  - Updating phpunit/phpunit (4.8.35 => 4.8.36): Loading from cache
  - Updating symfony/stopwatch (v2.8.20 => v2.8.26): Loading from cache
  - Updating symfony/process (v2.8.20 => v2.8.26): Loading from cache
  - Updating symfony/finder (v2.8.20 => v2.8.26): Loading from cache
  - Updating symfony/filesystem (v2.8.20 => v2.8.26): Loading from cache
  - Updating symfony/event-dispatcher (v2.8.20 => v2.8.26): Loading from cache
  - Updating symfony/polyfill-mbstring (v1.3.0 => v1.4.0): Loading from cache
  - Updating symfony/debug (v2.8.20 => v2.8.26): Downloading (100%)         
  - Updating symfony/console (v2.8.20 => v2.8.26): Downloading (100%)         
  - Updating friendsofphp/php-cs-fixer (v1.11.6 => v1.13.1): Loading from cache   

Testing Instructions

The CMS continues to function as normal, the unit testing environment does not fail

avatar mbabker mbabker - open - 12 Jul 2017
avatar mbabker mbabker - change - 12 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jul 2017
Category External Library Libraries
avatar mbabker mbabker - change - 12 Jul 2017
Milestone Added:
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2017
Category External Library Libraries Repository External Library Composer Change Libraries
avatar mbabker mbabker - change - 26 Jul 2017
Labels Added: ?
Removed: ?
avatar mbabker mbabker - change - 26 Jul 2017
The description was changed
avatar mbabker mbabker - edited - 26 Jul 2017
avatar mbabker mbabker - change - 27 Jul 2017
The description was changed
avatar mbabker mbabker - edited - 27 Jul 2017
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2017
Category External Library Libraries Repository Composer Change Repository Unit Tests External Library Composer Change Libraries
avatar mbabker mbabker - change - 28 Jul 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jul 2017
Category External Library Libraries Repository Composer Change Unit Tests Repository External Library Composer Change Libraries
avatar wilsonge
wilsonge - comment - 5 Aug 2017

@photodude can you help with appveyor here. looks like we need to install the ldap php package on appveyor

avatar photodude
photodude - comment - 5 Aug 2017

@wilsonge I'm out on vacation with just my phone for a couple more days. I'll look at it as soon as I'm back.

avatar wilsonge
wilsonge - comment - 5 Aug 2017

Thankyou! Have a lovely holiday!!

avatar joomla-cms-bot joomla-cms-bot - change - 5 Aug 2017
Category External Library Libraries Repository Composer Change Unit Tests Repository External Library Composer Change Libraries
avatar mbabker mbabker - change - 5 Aug 2017
Labels Removed: ?
avatar mbabker
mbabker - comment - 5 Aug 2017

For now I've added the --ignore-platform-reqs flag for AppVeyor (same as Travis) so it doesn't fail out on the ext/ldap dependency. Since we aren't actually running LDAP related tests on the CMS repo, it's not a big deal for now, but at some point we probably want to not rely on that flag.

avatar mbabker mbabker - change - 10 Aug 2017
The description was changed
avatar mbabker mbabker - edited - 10 Aug 2017
avatar mbabker mbabker - change - 10 Aug 2017
Labels Added: ?
avatar wilsonge
wilsonge - comment - 10 Aug 2017

Merging with this but when @photodude is back from holidays and ready to go again would be good to properly fix this!

avatar wilsonge wilsonge - change - 10 Aug 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-10 13:35:06
Closed_By wilsonge
avatar wilsonge wilsonge - close - 10 Aug 2017
avatar wilsonge wilsonge - merge - 10 Aug 2017
avatar photodude
photodude - comment - 10 Aug 2017

@wilsonge @mbabker I've look a little into the LDAP and how to set it up. From what I read you have to have a version of PHP that is compiled for LDAP. That makes enabling LDAP a bit more difficult. I think for linux there may be precompiled packages with LDAP, and looking over the windows options the packages might be LDAP ready packages. (I haven't used LDAP before so I'm learning about installing and using it as I go)

avatar mbabker
mbabker - comment - 10 Aug 2017

With the Precise images you could compile in LDAP pretty easily (see joomla-framework/ldap@bdba4bb). That same config doesn't work with the new Trusty images. And that's just with Travis. Windows (and AppVeyor) are an entirely different beast.

avatar mbabker
mbabker - comment - 10 Aug 2017

(BTW that setup is very close to how Symfony's setting up Travis so they can run tests on their LDAP component, for this repo that should be all that's needed since the actual client tests would need to be done in the Framework package repo going forward until we have a proper acceptance test system which should validate the LDAP authentication plugin functions correctly within a Joomla install)

avatar photodude
photodude - comment - 10 Aug 2017

I'm guessing the issue on travis is their trusty image doesn't have ldap-utils whitelisted for apt-get. I'll double check if that is the case.

avatar photodude
photodude - comment - 10 Aug 2017

Well ldap-utils is whitelisted for travis trusty images https://github.com/travis-ci/apt-package-whitelist/blob/master/ubuntu-trusty#L4043 so there shouldn't be an issue. (maybe it's pathed a little different than the precise images)

avatar mbabker
mbabker - comment - 10 Aug 2017

It's not apt that's the issue, I came across travis-ci/travis-ci#7067 and didn't really put much effort into testing the LDAP setup on Trusty (Symfony rolled back to Precise because of that issue, see symfony/symfony#23612).

Add a Comment

Login with GitHub to post a comment