Feeling Lucky
[#17073] - Reference issue #17065 - REGRESSION[4.0]: Database driver limit/offset not working anymore for SQL strings
- Closed
- 11 Jul 2017
- Medium
- Build: staging
- # 17073
- joeforjoomla:4.0-dev
Pull Request for Issue #17065 .
Summary of Changes
Allow to set a LIMIT clause for direct queries.
Testing Instructions
Expected result
Actual result
Documentation Changes Required
joeforjoomla
- comment
- 11 Jul 2017
I confirm you that changing the code as you suggested and adding one more processLimit call works:
if ($this->sql) { return $this->sql; }
to
if ($this->sql) { $this->sql = $this->processLimit($this->sql, $this->limit, $this->offset); return $this->sql; }
mbabker
- comment
- 11 Jul 2017
joomla-framework/database@a21ee68 fixes it in the Framework repo. We just need to merge the change up to the 2.0 branch then run a composer update here to pull in the change.
This PR can be closed out and we can close the issue once the merge has been finished.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-11 15:19:42 |
| Closed_By | ⇒ | joeforjoomla |
joomla-cms-bot
- | Category | ⇒ | External Library Libraries |
joeforjoomla
- comment
- 11 Jul 2017
Thanks Michael, sounds great.
I'll close the issue as well when the merge has been completed.
Just wanted to point you out an idea about the issue and how to fix it. I've not so much knowledge of the Framework repository that you are merging into J4