[#17071] - [4.0] remove popover
- Fixed in Code Base
- 28 Jul 2017
- Medium
- Build: 4.0-dev
- # 17071
- Diff
- brianteeman:com_banners
- Pending continuous-integration/appveyor/branch Waiting for AppVeyor build to complete Details
- Failure continuous-integration/drone/push the build failed Details
- Error continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
This is a pr for #17044 to remove the redundant popovers.
PURELY for the purpose of testing this concept I have quickly displayed the remaining popover as inline text - THIS PART IS NOT FOR REVIEW - it is just to demonstrate how few remaining descriptions we will have
In most cases the description could be simply removed
In some cases by adjusting the label the description could be removed.
Of the remaining descriptions some have been updated to remove redundancy and duplication but they need further review/testing but that is not part of this pr
Strings that are no longer used have been deleted unless they are in a global language file
References to labels and descriptions in Filters have been removed as they were neither being used not did 99% of them even exist. NOTE I did not look at the filters in /components as i could not see where or if they are even being used
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners Language & Strings Layout |
Just gone through the list of strings (haven't matched them to the XML files). Largely this looks ok although there's a couple where I'm a bit uncertain
| Labels |
Added:
?
?
|
||
| Category | Administration com_banners Language & Strings Layout | ⇒ | Administration com_banners com_contact Language & Strings Layout |
| Title |
|
||||||
| Category | Administration com_banners Language & Strings Layout com_contact | ⇒ | Administration com_banners com_contact com_users Language & Strings Layout |
| Category | Administration com_banners Language & Strings Layout com_contact com_users | ⇒ | Administration com_banners com_contact com_menus com_users Language & Strings |
| Category | Administration com_banners Language & Strings com_contact com_users com_menus | ⇒ | Administration com_banners com_contact com_joomlaupdate com_menus com_users Language & Strings |
| Category | Administration com_banners Language & Strings com_contact com_users com_menus com_joomlaupdate | ⇒ | Administration com_banners com_contact com_joomlaupdate com_menus com_messages com_users |
| Labels |
Removed:
?
|
||
| Category | Administration com_banners com_contact com_users com_menus com_joomlaupdate com_messages | ⇒ | Administration com_banners com_contact com_joomlaupdate com_menus com_messages com_newsfeeds com_users |
| Category | Administration com_banners com_contact com_users com_menus com_joomlaupdate com_messages com_newsfeeds | ⇒ | Administration com_banners com_contact com_finder com_joomlaupdate com_menus com_messages com_newsfeeds com_redirect |
| Category | Administration com_banners com_contact com_menus com_joomlaupdate com_messages com_newsfeeds com_finder com_redirect | ⇒ | Administration com_banners com_contact com_finder com_joomlaupdate com_menus com_messages com_newsfeeds com_plugins |
| Category | Administration com_banners com_contact com_menus com_joomlaupdate com_messages com_newsfeeds com_finder com_plugins | ⇒ | Administration com_admin com_banners com_categories com_config com_contact com_content com_fields com_finder com_joomlaupdate com_languages com_menus |
| Category | Administration com_banners com_contact com_menus com_joomlaupdate com_finder com_admin com_categories com_config com_content com_fields com_languages | ⇒ | Administration com_admin com_associations com_banners com_categories com_config com_contact com_content com_fields com_finder com_installer com_joomlaupdate com_languages com_menus |
| Title |
|
||||||
@brianteeman conflicts
Forgot to do the front end components as well - doing that now
Conflicts resolved - again
Just modules left to finish reviewing
Awesome. Let me know when it's ready to review :)
I just need to finish reviewing the modules and solve one part of com_content and then it's ready for review. Hopefully this time tomorrow
| Category | Administration com_banners com_contact com_menus com_joomlaupdate com_finder com_admin com_categories com_config com_content com_fields com_languages com_associations com_installer | ⇒ | Administration com_admin com_associations com_banners com_cache com_categories com_checkin com_config com_contact com_content com_fields com_finder |
ok i am done. i have updated the original post and this is ready for review. Please read the notes carefully
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
From what I can tell the drone issue is unrelated
@brianteeman it is unrelated and it was patched in couple PRs that never made it to the core
If you get conflicts done here I'll get it merged
What again :(
I will do it in the morning and hopefully it will be !edged before any more
It's the PR of your's I merged this morning :) I'll get this merged next!
Yes I know.i am just pulling your chain
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-28 09:25:37 |
| Closed_By | ⇒ | wilsonge |
Conflicts resolved - hopefully for the last time
Only for this PR I'm afraid ;)
Thanks
+1