Cool thank you :) Will test it asap

Test failed :(

Select 'Site Map' as parent_id and the list does indeed filter to show the correct subitems but the 'search tools disappear' - you need to add parent_id and a.parent_id to $config['filter_fields'] in the model constructor otherwise the 'search tools' disappear when you select a parent filter (with no other filters enabled).

Additionally it would be good for the parent item list to be filtered based on the main 'menu filter'.

@GeraintEdwards i altered your unsuccessfully Test at issue Tracker.

Thanks @GeraintEdwards now resolved.

I have tested this item ✅ successfully on ad24cdb

Menu items are filtered correctly and the filter remains visible in the 'search tools'

Now updated @coolcat-creations @GeraintEdwards to include a custom field type which dynamically filters the menu items by menu type if the menu items in the list are already filter by type.

@rdeutz jenkis php70 docker isn't connecting?

I have tested this item ✅ successfully on 0b3ed6f

Thank you, it works! Great improvement for large sites :)

@GeraintEdwards can you please retest?

I have tested this item ✅ successfully on 0b3ed6f

Filtering by menu type is a big functional improvement - thanks for adding it in.

RTC after two successful tests.

@tonypartridge you don't need to care about the new jenkins setup, we are still in testing mode

That's fine, just didn't think it gets accepted unless all tests are passed.

Thanks!

On 12 Jul 2017, 10:45 +0100, Robert Deutz notifications@github.com, wrote:

@tonypartridge you don't need to care about the new jenkins setup, we are still in testing mode
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

travis and drone are required

Made some slight changes as per @Quy 's request. Should not need retesting, nothing has changed apart from code style.

Actually, the lines should be moved after line 39.

@rdeutz has someone changed AppVeyor? This passed last week without issue, all I have done is moved language strings around in the .xml for @Quy ?

@tonypartridge it's nothing you can really count on, if they have failed I look into it and most of the time it is simply a wrong test result

I’ve just copied the core Joomla! Menuitem.php type……..

On 19 Jul 2017, 13:14 +0100, Michael Babker notifications@github.com, wrote:

@mbabker commented on this pull request.
In administrator/components/com_menus/models/fields/menuitembytype.php:

•                      foreach ($menu->links as $link)
  

•                           {
  

•                                   $levelPrefix = str_repeat('- ', $link->level - 1);
  

•                                   // Displays language code if not set to All
  

•                                   if ($link->language !== '*')
  

•                                   {
  

•                                           $lang = ' (' . $link->language . ')';
  

•                                   }
  

•                                   else
  

•                                   {
  

•                                           $lang = '';
  

•                                   }
  

•                                   $groups[$menu->title][] = JHtml::_('select.option',
  

•                                           $link->value, $levelPrefix . $link->text . $lang,
  

If you're going to split the parameters across multiple lines, there should be one parameter per line (this line has two)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Thanks @mbabker 👍

On 26 Jul 2017, 00:37 +0100, Michael Babker notifications@github.com, wrote:

Merged #17060.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.