?
avatar mino182
mino182
10 Jul 2017

Steps to reproduce the issue

  • change com_tags option "Language Filter" to "Current"
  • Open single tag view to see articles with selected tag
  • change frontend language
  • you can change language to any, still same articles are displayed, like you didn't change language

Expected result

  • articles in single tag view should change depend on selected language.

System information (as much as possible)

Joomla 3.7.3

Additional comments

Problem is in file "plugins/system/languagefilter/languagefilter.php". If I replace changes from PR #12306 to code from Joomla 3.7.2 problem disappears.

Thanks.

avatar mino182 mino182 - open - 10 Jul 2017
avatar joomla-cms-bot joomla-cms-bot - labeled - 10 Jul 2017
avatar tonypartridge
tonypartridge - comment - 11 Jul 2017

Confirm not working.

avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Jul 2017
Status New Confirmed
avatar infograf768 infograf768 - change - 11 Jul 2017
Title
com_tags issue with plugin System - Language Filter
REGRESSION: com_tags issue with plugin System - Language Filter
avatar infograf768 infograf768 - edited - 11 Jul 2017
avatar infograf768
infograf768 - comment - 11 Jul 2017

Problem is in file "plugins/system/languagefilter/languagefilter.php". If I replace changes from PR #12306 to code from Joomla 3.7.2 problem disappears.

Do you mean just reverting the part in the languagefilter plugin or the whole PR?

avatar infograf768
infograf768 - comment - 11 Jul 2017

@andrepereiradasilva
This looks rather urgent as beta is to be released today.

avatar franz-wohlkoenig franz-wohlkoenig - change - 11 Jul 2017
Priority Medium Urgent
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 11 Jul 2017

set Priority in Issue Tracker on "Urgent".

avatar tonypartridge
tonypartridge - comment - 11 Jul 2017

I think com_tags just needs bought up to date with JSession. Better for @redutz to review

On 11 Jul 2017, 10:35 +0100, Franz Wohlkönig notifications@github.com, wrote:

set Priority in Issue Tracker on "Urgent".

You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

avatar mino182
mino182 - comment - 11 Jul 2017

@infograf768 I mean reverting just part of languagefilter.php

avatar infograf768
infograf768 - comment - 11 Jul 2017

Let's see what @rdeutz says.
If this can't be solved in com_tags, we may revert the part concerning the languagefilter.

avatar rdeutz
rdeutz - comment - 11 Jul 2017

I will let this open and make the beta release, next week we have a RC1 and we have time to fix it meanwhile.

avatar infograf768
infograf768 - comment - 11 Jul 2017

My test here show that if we set the languagefilter plugin Cookie Lifetime to Year, it works fine.
It breaks when set to Session.

avatar infograf768
infograf768 - comment - 11 Jul 2017

Will make a patch modifying that part of languagefilter (while keeping some improvement there)
When the language filter is set to session, com_tags (and possibly some other 3pd extensions) is not fetching that specific cookie setting.
It is imho the easiest way to solve the issue.

avatar infograf768 infograf768 - change - 12 Jul 2017
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2017-07-12 08:03:10
Closed_By infograf768
avatar infograf768 infograf768 - close - 12 Jul 2017
avatar infograf768
infograf768 - comment - 12 Jul 2017

In fact, the problem was in the helpers.
Please test #17084

@mino182
@tonypartridge

Add a Comment

Login with GitHub to post a comment