[#17047] - Remove unnecessary inline style parameter
- Closed
- 10 Jul 2017
- Medium
- Build: staging
- # 17047
- Diff
- Mategm:patch-1
User tests: Successful: Unsuccessful:
Someone added an unnecessary inline style with "display. none" parameter to the line 144.
This line makes an input field for article ordering numbers when the selected listing is the ordering.
This function not work with the inline style parameter.
Pull Request for Issue # .
Summary of Changes
Line 144, removed this: style="display: none;"
Testing Instructions
Choose the futured articles in backend and change the column ordering to the first column (sequence?)
Expected result
Between the drag&drop icon and the checkbox appear the input field with the article ordering number.
Actual result
If you choose the ordering sequence, nothing else between the drag&drop and checkbox
Documentation Changes Required
Please help for here.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content |
Hello Franz
Sorry, it is my first edit here and my English is not too strong.
I dont understand what you like. Could you help me please?
I make only one change in line 144.
Here an input field.
Earlier someone added it this code: style="display: none;"
Its parameter block this input field function.
Before:
After:
Thank you
--
Mategm
thanks for your Contribution. To get an PR merged it has to be tested, normally 2 successfully Test. Than a Maintainer decide if it can be merged. To test People have to know, how to test. This to explain in a non-technical Lang. more People can test. Also for Maintainers its helpful why you change what for what Reason.
It is correct for this to be display:none
The ordering of featured articles is done by drag and drop (as it is with all articles) and in order for this to work it requires this field even though we dont want it to be displayed
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-10 11:23:36 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
Are you sure?
An inline style is required?
How to you use the drag&drop with more pages?
If you choose other like "Title" or "Author", the input field not displayed
with and without the inline style parameter. This is provided by the system.
The input field only apper when you choose the ordering.
With the inline style this not work.
And how to order the timed content without this input field when the
article listing is not the newest or older?
--
Gábor
2017-07-10 13:23 GMT+02:00 Brian Teeman notifications@github.com:
It is correct for this to be display:none
The ordering of featured articles is done by drag and drop (as it is with
all articles) and in order for this to work it requires this field even
though we dont want it to be displayed—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#17047 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AT5BLyAHZkLm3KZ50v1lCVQUfQDTVa9eks5sMgnBgaJpZM4OSqD4
.
yes i am sure
can you give please Test Instructions, what Changes, expected Result, etc.?