[#17042] - Show a sample editor on the CodeMirror plugin config page.
- Fixed in Code Base
- 10 May 2018
- Medium
- Build: staging
- # 17042
- Diff
- okonomiyaki3000:CodeMirror-Sample
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Added a CodeMirror editor to the 'Appearance Options' tab of the CodeMirror plugin config page to take the guesswork out of configuring CodeMirror's appearance.
Testing Instructions
Open the CodeMirror config page and click on th 'Appearance Options' tab. Change the theme, font, etc. Save changes.
Expected result
The new appearance settings will be shown in the embedded editor field.
Actual result
Should be as expected.
Documentation Changes Required
No but there are a couple of new strings in the language file.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Front End Plugins |
There must be a better way of doing this without adding inline jquery javascript and it really needs to be something that is translatable and not hard coded in english
@brianteeman
Serves me right for replying before coffee
I understand what you are doing now - not sure of the benefit of having it - when I looked at the options page it confused me more than it helped me
Maybe it needs a different label than "sample text"
Layout preview?
Configuration preview?
Maybe just 'Preview'?
| Labels |
Added:
?
?
|
||
Here's that pr-merge error again. What is this?
Don't believe that pr-merge error. There is no problem with this PR.
It would be nice to see the preview when Theme is changed without having to click Save button each time.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17042.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17042.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17042.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-10 00:59:35 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on f2fac83
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17042.