? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
9 Jul 2017

Pull Request for Issue # .

Summary of Changes

Changes title to h1. More descriptive title. Removes input placeholders. Make input labels visible.

Before

a11y-login1

After

a11y-login2

Documentation Changes Required

avatar ciar4n ciar4n - open - 9 Jul 2017
avatar ciar4n ciar4n - change - 9 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jul 2017
Category Administration Language & Strings Modules Templates (admin) Front End Templates (site)
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 9 Jul 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Jul 2017

I have tested this item successfully on 0b2e1bd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17039.

avatar wilsonge
wilsonge - comment - 9 Jul 2017

Can you fix conflicts please :)

avatar ciar4n ciar4n - change - 9 Jul 2017
Labels Added: ? ?
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jul 2017
Category Administration Language & Strings Modules Templates (admin) Front End Templates (site) Administration Language & Strings Modules Templates (admin)
avatar ciar4n
ciar4n - comment - 9 Jul 2017

Done!

avatar brianteeman
brianteeman - comment - 9 Jul 2017
  1. I dont understand the reasoning behind changing the text - i am not sure I see the need but mayeb yu have some reasoning I dont understand yet
  2. Why did you create a new string instead of editing the current one
  3. As it is a title then the new string should be capital case
avatar armenos armenos - test_item - 10 Jul 2017 - Tested successfully
avatar armenos
armenos - comment - 10 Jul 2017

I have tested this item successfully on 8e66bf1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17039.

avatar ciar4n
ciar4n - comment - 10 Jul 2017

@brianteeman

  1. This is what was suggested by @armenos. His reasoning was to make it clear to the user where he is.

  2. The same string was used for the log in button so a separate string was created to allow alternative text.

  3. Like this?..

a11y-login3

avatar brianteeman
brianteeman - comment - 10 Jul 2017
  1. OK

  2. Ah I thought the button used the existing JLOGIN string which is the string used on the front end. I would recommend changing the button to JLOGIN and simply editing the current string - less duplication

3.Sorry I actually meant sentence case not capital case but it looks just as good or even better as capital case

avatar C-Lodder
C-Lodder - comment - 11 Jul 2017

I'd even probably say remove the "Login" text about the 2 inputs. The form and button text are already pretty self explanatory.

avatar brianteeman
brianteeman - comment - 11 Jul 2017

@C-Lodder that is there so that the page had a title which is an a11y requirement

avatar ciar4n
ciar4n - comment - 12 Jul 2017
  1. Ah I thought the button used the existing JLOGIN string which is the string used on the front end. I would recommend changing the button to JLOGIN and simply editing the current string - less duplication
  1. Sorry I actually meant sentence case not capital case but it looks just as good or even better as capital case

Done

Conflicts fixed.

avatar wilsonge wilsonge - change - 12 Jul 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-12 09:08:19
Closed_By wilsonge
avatar wilsonge wilsonge - close - 12 Jul 2017
avatar wilsonge wilsonge - merge - 12 Jul 2017

Add a Comment

Login with GitHub to post a comment