[#17033] - [4.0] Stop early exiting the Smart Search indexer
- Fixed in Code Base
- 30 Jul 2017
- Medium
- Build: 4.0-dev
- # 17033
- Diff
- mbabker:indexer-no-early-exit
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
Throughout our non-HTML handling controllers, we are commonly early exiting the application instead of running a full request. We should be consistently running the full application and ensuring all requests go through the full cycle. The use of this early exit practice is generally to avoid having the responses butchered by plugins, but this practice is hugely subpar and if we intend to follow through on #14176 then this is a required step anyway.
This PR changes the Smart Search indexing process to remove the early exit logic.
Testing Instructions
The Smart Search indexer works correctly.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
Maybe? It runs fine when I tested, but admittedly I turn off stats collection every time I re-run the installer on my local.
brianteeman
- | Milestone |
Added: |
||
| Milestone |
Added: |
||
Didn't turn off stats collection and this worked. So seems good
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-30 22:49:04 |
| Closed_By | ⇒ | wilsonge |
I'm assuming we need to fix the stats plugin HTML injection before this works?