? ? Failure

User tests: Successful: Unsuccessful:

avatar photodude
photodude
9 Jul 2017

Pull Request for Issue test schema use wrong types.

Summary of Changes

change some fields from TEXT or TIMESTAMP to DATETIME

Testing Instructions

code review / tests pass

Expected result

tests pass and have correct types

Actual result

some fields used TEXT or TIMESTAMP when they should have been using DATETIME

Documentation Changes Required

None, this is a testing setup fix

avatar photodude photodude - open - 9 Jul 2017
avatar photodude photodude - change - 9 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jul 2017
Category Unit Tests
avatar photodude
photodude - comment - 14 Aug 2017

@mbabker @wilsonge, bump for review and merge consideration

avatar wilsonge wilsonge - change - 15 Aug 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-15 11:06:57
Closed_By wilsonge
avatar wilsonge wilsonge - close - 15 Aug 2017
avatar wilsonge wilsonge - merge - 15 Aug 2017
avatar wilsonge
wilsonge - comment - 15 Aug 2017

Given this is only doing tests and it's consistent with what we already have in the installation sql files i'm good with this

avatar photodude
photodude - comment - 15 Aug 2017

Thanks @wilsonge, glad to help make things in the tests a little more consistent with the installs.

Add a Comment

Login with GitHub to post a comment