? ? ? Success

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
9 Jul 2017

Pull Request for Issue ##16894 (related) .

Summary of Changes

Changes 'Menu Class Suffix' to 'Menu Class'.

Testing Instructions

Add class to menu module using the 'Menu Class' field (no space). Check frontend and ensure class has been added correctly to the ul tag.

<ul class="nav flex-column yourClass">

Expected result

Actual result

Documentation Changes Required

Yes

avatar ciar4n ciar4n - open - 9 Jul 2017
avatar ciar4n ciar4n - change - 9 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Jul 2017
Category Language & Strings Modules Front End
avatar dgt41 dgt41 - test_item - 9 Jul 2017 - Tested successfully
avatar dgt41
dgt41 - comment - 9 Jul 2017

I have tested this item successfully on fdc5e92


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17026.

avatar brianteeman
brianteeman - comment - 9 Jul 2017

Will you be making a similar change to the modules?

avatar brianteeman
brianteeman - comment - 9 Jul 2017

sorry just seen the modules pr

avatar brianteeman brianteeman - change - 10 Jul 2017
Title
Change 'Menu Class Suffix' to 'Menu Class'
[4.0] Change 'Menu Class Suffix' to 'Menu Class'
avatar brianteeman brianteeman - edited - 10 Jul 2017
avatar brianteeman brianteeman - change - 10 Jul 2017
Title
Change 'Menu Class Suffix' to 'Menu Class'
[4.0] Change 'Menu Class Suffix' to 'Menu Class'
avatar ciar4n ciar4n - change - 10 Jul 2017
Labels Added: ? ?
avatar brianteeman brianteeman - change - 19 Jul 2017
Milestone Added:
avatar brianteeman brianteeman - change - 19 Jul 2017
Milestone Added:
avatar davidsteltz davidsteltz - test_item - 25 Aug 2017 - Tested successfully
avatar davidsteltz
davidsteltz - comment - 25 Aug 2017

I have tested this item successfully on 1ff2df8

test


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17026.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Aug 2017

@dgt41 can you please retest?

avatar C-Lodder C-Lodder - test_item - 3 Oct 2017 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 3 Oct 2017

I have tested this item successfully on 1ff2df8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17026.

avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Oct 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Oct 2017

RTC after two successful tests.

avatar wilsonge wilsonge - change - 9 Oct 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-10-09 10:24:10
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 9 Oct 2017
avatar wilsonge wilsonge - merge - 9 Oct 2017

Add a Comment

Login with GitHub to post a comment