[#17023] - [4.0] Change 'Module Class Suffix' to 'Module Class'
- Closed
- 28 Aug 2017
- Medium
- Build: 4.0-dev
- # 17023
- Diff
- ciar4n:mod-class
- Success hound No violations found. Woof! Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
- Failure continuous-integration/drone/pr the build failed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #16894 .
Summary of Changes
Changes 'Module Class Suffix' to 'Module Class'.
Testing Instructions
Add class to module using the 'Module Class' field (no space). Check frontend and ensure class has been added correctly.
Eg.
<div class="card yourClass">
Expected result
Actual result
Documentation Changes Required
Yes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Modules Templates (admin) Front End |
HTML is for the browser, not the user, to read and process. The only people that are going to groan about it are the ones trying to optimize the HTML response anyway and they're going to do things like enable compression and minifiers anyway.
I think we merged PRs to remove such spaces in the past, that's why I said it. Personally I don't care at all about that space.
| Labels |
Added:
?
?
|
||
brianteeman
- | Milestone |
Added: |
||
| Milestone |
Added: |
||
I have tested this item
The class was added, but the backend label is broken.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17023.
Also just realized the space is NOT being added automatically.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17023.
I thought about fixing this, but then I noticed that "moduleclass_sfx" is a field in the database, so if that is changed for the installers, then when that person updates it won't be changed so the existing sfx will be lost for ALL modules!!!! that doesn't sound very smart.
Simply changing echo $params->get('moduleclass_sfx') to echo " " . trim($params->get('moduleclass_sfx'))
& echo $moduleclass_sfx; to echo " " . trim($moduleclass_sfx); should fix the space problem
infact, the more I think about this the more I think its a horrible idea... we just had a pr to remove the " " and now we're putting it back? It is a suffix so I'm not sure I see the valid reason to change it. We've done a lot of just changing stuff cause, I'm not sure we want to continue that trend.
@N6REJ PR to remove the " "? This class suffix field has been in Joomla for years. With modern CSS architecture, a suffix on a block level class is a ridiculous idea and you will be hard pushed to find anyone actually using it in that manner. And frankly if they are, you would seriously have to question the code.
Closing as to many conflicts after #17447, currently effects user data and..
We've done a lot of just changing stuff cause, I'm not sure we want to continue that trend.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-28 08:21:48 |
| Closed_By | ⇒ | ciar4n |
I foresee someone complaining about a useless space in the module class in case no class is specified in the parameter.