[#17009] - fixed missing own asset rule for parent recursive get access rule
- Fixed in Code Base
- 5 Dec 2019
- Medium
- Build: staging
- # 17009
- Diff
- julienV:fix-parent-recursive-access-rule
- Success Hound No violations found. Woof! Details
- Failure continuous-integration/drone/pr the build failed Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Fixed a failing strict comparison operator, which prevents parent recursive asset rule to work properly
self::$assetPermissionsParentIdMapping[$extensionName][$id] is the result of a database query, so the type of self::$assetPermissionsParentIdMapping[$extensionName][$id]->id is string.
$assetId if an integer, so the test result is false, but it should be true...
Testing Instructions
Not easy to test, as this parameters don't seem to be use directly in joomla core...
Expected result
Actual result
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
sure, i can change it to
(int) self::$assetPermissionsParentIdMapping[$extensionName][$id]->id, but does it really makes it more readable ? the variable name is so long, you don't really see the type casting.
sure, i can change it to
(int) self::$assetPermissionsParentIdMapping[$extensionName][$id]->id, but does it really makes it more readable ? the variable name is so long, you don't really see the type casting.
it a not only about readability, which i argue it is quite readable , it is not too long,
it will also make clear to people looking at the code in the future what the comparison does, thus avoid the bug being re-introduced by future modifications
All this critique about type casting and no follow on...
(Needs merge conflicts resolved)
there was no conflict, merging of staging branch went fine...
franz-wohlkoenig
- | Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17009.
| Labels |
Removed:
J3 Issue
|
||
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17009.
| Labels |
Added:
?
|
||
Finally a happy end. Thanks
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-05 22:47:45 |
| Closed_By | ⇒ | HLeithner |
IMO It would be better to set this more explicitly, I mean using
(int) $a !== $b. I know that does not change anything in php but for people it is more explicit.