? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
6 Jul 2017

Pull Request for Issue #16996

Summary of Changes

Decoding the $value of the mail field when it used in the body of the mail as otherwise it is displayed in the mail as htmlentities.

Testing Instructions

Create one contact
Create a mail custom field for example one list custom field and put values with non latin characters (for example Greek characters like Ολοκλήρωση)
Same if you use a text custom field and enter Greek Characters when the contact is displayed on frontend.
Try to sent email from contact form on frontend.

Expected result

Η εγκατάσταση της PHP απαιτεί το JSON για Joomla να είναι εγκατεστημένο.
Διαμονή: Ολοκλήρωση

Actual result

Η εγκατάσταση της PHP απαιτεί το JSON για Joomla να είναι εγκατεστημένο.
Διαμονή: Ολοκλήρωση

avatar infograf768 infograf768 - open - 6 Jul 2017
avatar infograf768 infograf768 - change - 6 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jul 2017
Category Front End com_contact
avatar infograf768
infograf768 - comment - 6 Jul 2017
avatar laoneo
laoneo - comment - 6 Jul 2017

Does this not depend how the mail is sent? I guess if the mail is sent in HTML mode, then it is correct without the patch, otherwise with it.

avatar zero-24
zero-24 - comment - 6 Jul 2017

IIRC the contact mail is send via text ;)

avatar infograf768
infograf768 - comment - 6 Jul 2017

IIRC the contact mail is send via text ;)

indeed, thus the reason for this pr. please confirm patch.

avatar infograf768 infograf768 - change - 7 Jul 2017
Title
[com_fields] Value for the custom mail field in contacts should not be htmlentities() encoded when it sent in the mail body
[com_fields] Value for the custom mail field in contacts should not be htmlentities() encoded when it is sent in the mail body
avatar infograf768 infograf768 - edited - 7 Jul 2017
avatar infograf768
infograf768 - comment - 7 Jul 2017

@laoneo
See : https://github.com/joomla/joomla-cms/blob/staging/components/com_contact/controllers/contact.php#L209-L215

as you can see, we do not have any $mail->isHtml(true); in the code

avatar laoneo laoneo - test_item - 7 Jul 2017 - Tested successfully
avatar laoneo
laoneo - comment - 7 Jul 2017

I have tested this item successfully on 94ec647


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17005.

avatar AlexRed AlexRed - test_item - 7 Jul 2017 - Tested successfully
avatar AlexRed
AlexRed - comment - 7 Jul 2017

I have tested this item successfully on 94ec647

Patch ok for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17005.

avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Jul 2017
The description was changed
Status Pending Ready to Commit
avatar joomla-cms-bot joomla-cms-bot - edited - 7 Jul 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Jul 2017

RTC after two successful tests.

avatar rdeutz rdeutz - close - 7 Jul 2017
avatar rdeutz rdeutz - merge - 7 Jul 2017
avatar rdeutz rdeutz - change - 7 Jul 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-07 18:50:17
Closed_By rdeutz
Labels Added: ? ?

Add a Comment

Login with GitHub to post a comment