? Success

User tests: Successful: Unsuccessful:

avatar matrikular
matrikular
4 Jul 2017

Pull Request for Issue #16968.

Summary of Changes

Change params variable to reflect merged state (in address sub-layout).

Testing Instructions

See #16968 (comment)

Expected result

The mentioned field values and icons are shown to the user.

Actual result

They are not.

avatar matrikular matrikular - open - 4 Jul 2017
avatar matrikular matrikular - change - 4 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2017
Category Front End com_contact
avatar richard67 richard67 - test_item - 4 Jul 2017 - Tested successfully
avatar richard67
richard67 - comment - 4 Jul 2017

I have tested this item successfully on 8d0e5f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16971.

avatar bembelimen bembelimen - test_item - 4 Jul 2017 - Tested successfully
avatar bembelimen
bembelimen - comment - 4 Jul 2017

I have tested this item successfully on 8d0e5f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16971.

avatar richard67
richard67 - comment - 4 Jul 2017

It seems drone failed for reasons not related to this PR (some phpcs script missing).

avatar gorgonz
gorgonz - comment - 4 Jul 2017

I saw the bug after updating. Gave it a try by exchanging my override with this new version in three different websites. Works fine now :-)

avatar infograf768 infograf768 - change - 5 Jul 2017
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 5 Jul 2017

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16971.

avatar AlexRed
AlexRed - comment - 5 Jul 2017

I think we need same edit also in the template beez override
templates/beez3/html/com_contact/contact/default_address.php

avatar lunalars
lunalars - comment - 5 Jul 2017

hm, if all template overrides have to be updated, isn't it a b/c break then? in other words: something was changed and now breaks template overrides.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16971.

avatar dgt41
dgt41 - comment - 5 Jul 2017

if all template overrides have to be updated, isn't it a b/c break then

Not according to the B/C promise:

6.1.7 Rendered markup

For the time being, rendered markup is not subject to our backwards compatibility promise. We will try not to change markup in such a way that a site might render differently, but we can't promise not to break anything at the present time. We will work on defining ways in which we might make a backwards compatibility promise for markup in the future, but we do not currently have a satisfactory consensus on a workable standard.

avatar lunalars
lunalars - comment - 5 Jul 2017

ah, ok. thanks for the info!

avatar dgt41
dgt41 - comment - 5 Jul 2017

@lunalars actually the mark up with this PR remains the same so this is just a bug fix and it shouldn't affect you unless you already have created an override with the latest version

avatar lunalars
lunalars - comment - 5 Jul 2017

@dgt41 I am affected, but I'm not sure why. Maybe I'm doing somthing wrong in a plugin I created, which adds some fields to the contact edit form in backend. These fields are saved with the params of the contact.
In my template overrides I was able to get these params with
$this->params->get('paramname'),
but now I have to use
$this->item->params->get('paramname') or $this->contact->params->get('paramname').
This only applies to the "custom" params, the "core" params work as before.

Now I'm confused :-) But maybe I should just add my fields in a different way.

Edit: And yes, my problem is not related to this PR

avatar zero-24 zero-24 - change - 5 Jul 2017
Status Ready to Commit Pending
avatar zero-24
zero-24 - comment - 5 Jul 2017

I'm switching back to pending based on a special request by @matrikular


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16971.

avatar matrikular
matrikular - comment - 5 Jul 2017

Thanks @zero-24. I'll post an update soon (this evening).

avatar matrikular
matrikular - comment - 5 Jul 2017

First of all, I feel responsible for this and do want to make it right. You can be assured, that it is not my intention to hide behind some "yet unwritten", "debatable", "between the lines" interpretation of the stated b/c promise regarding rendered markup.

That said, personally - I would expect every site owner / admin / webmaster to thoroughly check their overrides after each update and that a layout is hardly to keep free from "breaking" changes. A simple change in the data layer or parameter handling e.g. can very well affect the output.

So much for cheap excuses,...
I also think, in case of the address layout, it would be (already is) a b/c break in a way that, everyone that already has got an override, would need to update it because of the "new" variable being used. This is because in different from the default and custom fields layout, it uses $this->params variable directly, where the other two accessed the parameters via the variable $tparams or $params, therefore no layout wide renaming was needed.

I've reverted the changes back to the original state for the address layout and assigned the merged parameters to $this->params in the view. That way, there should be no need to change an already existing override. Well, at least not in this context (hopefully).

Some more tests are highly appreciated, thanks.

avatar richard67 richard67 - test_item - 5 Jul 2017 - Tested successfully
avatar richard67
richard67 - comment - 5 Jul 2017

I have tested this item successfully on 597a503

@matrikular Just when you had posted your previous comment I have finishing my test ;-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16971.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 5 Jul 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Jul 2017

I have tested this item successfully on 597a503


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16971.

avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Jul 2017
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Jul 2017

RTC after two successful tests.

avatar lunalars lunalars - test_item - 5 Jul 2017 - Tested successfully
avatar lunalars
lunalars - comment - 5 Jul 2017

I have tested this item successfully on 597a503

Fixes problem mentioned in #16968 and custom overrides.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16971.

avatar bayareajenn bayareajenn - test_item - 5 Jul 2017 - Tested successfully
avatar bayareajenn
bayareajenn - comment - 5 Jul 2017

I have tested this item successfully on 597a503

I tested this on four sites that had this issue and all tested great with the fix provided. Thank you!
Jenn


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16971.

avatar rdeutz rdeutz - close - 6 Jul 2017
avatar rdeutz rdeutz - merge - 6 Jul 2017
avatar rdeutz rdeutz - change - 6 Jul 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-06 07:33:58
Closed_By rdeutz
Labels Added: ?

Add a Comment

Login with GitHub to post a comment