? ? Success

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
4 Jul 2017

Summary of Changes

Creating a custom field group fails because of
datetime value: '' for column 'modified' at row 1

This pr fixes it.

avatar laoneo laoneo - open - 4 Jul 2017
avatar laoneo laoneo - change - 4 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2017
Category Administration com_fields
avatar wilsonge
wilsonge - comment - 4 Jul 2017

Wait why is this breaking? It's not like this in any other modified date fields i don't think

avatar laoneo
laoneo - comment - 4 Jul 2017

It works for fields so I compared the form with it and made the similar change https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_fields/forms/field.xml#L154.

avatar RonakParmar RonakParmar - test_item - 5 Jul 2017 - Tested successfully
avatar RonakParmar
RonakParmar - comment - 5 Jul 2017

I have tested this item successfully on 5f9e572


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16962.

avatar brianteeman brianteeman - change - 19 Jul 2017
Milestone Added:
avatar brianteeman brianteeman - change - 19 Jul 2017
Milestone Added:
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 20 Jul 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jul 2017

I have tested this item successfully on 5f9e572


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16962.

avatar joomla-cms-bot joomla-cms-bot - change - 20 Jul 2017
Milestone Removed:
avatar franz-wohlkoenig franz-wohlkoenig - change - 20 Jul 2017
Status Pending Ready to Commit
Easy No Yes
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 20 Jul 2017

RTC after two successful tests.

avatar zero-24 zero-24 - change - 17 Aug 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-08-17 22:54:33
Closed_By zero-24
Labels Added: ?
avatar zero-24 zero-24 - close - 17 Aug 2017
avatar zero-24 zero-24 - merge - 17 Aug 2017

Add a Comment

Login with GitHub to post a comment