? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
3 Jul 2017

Pull Request for Issue #16951 .

Summary of Changes

fixed item property

Testing Instructions

Load tags feed via /index.php?option=com_tags&view=tags&format=feed

Expected result

feed without Notice

Actual result

Notices in PHP error log

avatar alikon alikon - open - 3 Jul 2017
avatar alikon alikon - change - 3 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jul 2017
Category com_tags Front End
avatar franz-wohlkoenig franz-wohlkoenig - test_item - 3 Jul 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Jul 2017

I have tested this item successfully on 4f202b1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16955.

avatar brianteeman
brianteeman - comment - 4 Jul 2017

I have been unable to replicate the reported error but this change looks wrong to me

Assuming i am reading this correctly before this pr it would display
author alias or author
but now it displays
author alias or user id

and the change to remove the feed email negates the settings in global configuration

avatar alikon
alikon - comment - 4 Jul 2017

as it is now in the model we query only the #__tags table,
so we don't have an author email or author field,
i'll look if we can join #__tags and #__users tables

avatar alikon alikon - change - 4 Jul 2017
Labels Added: ?
avatar alikon
alikon - comment - 5 Jul 2017

is ready to test now

avatar Quy Quy - test_item - 7 Jul 2017 - Tested successfully
avatar Quy
Quy - comment - 7 Jul 2017

I have tested this item successfully on 5bc299c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16955.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 7 Jul 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Jul 2017

I have tested this item successfully on 5bc299c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16955.

avatar franz-wohlkoenig franz-wohlkoenig - change - 7 Jul 2017
Status Pending Ready to Commit
Easy No Yes
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 7 Jul 2017

RTC after two successful tests.

avatar rdeutz rdeutz - change - 8 Jul 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-08 10:00:59
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 8 Jul 2017
avatar rdeutz rdeutz - merge - 8 Jul 2017

Add a Comment

Login with GitHub to post a comment