[#16952] - Add deprecate messages to JError
- Fixed in Code Base
- 10 Aug 2017
- Medium
- Build: 3.8-dev
- # 16952
- Diff
- Digital-Peak:j3/jerror-cleanup
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
The JError class is deprecated since Joomla 1.7. Guess it is time to say good by for it in Joomla 4. If this pr get accepted, then I will remove all the JError calls in the 3 series, that we can safely remove the class in 4. But first I want to have an agreement if the replacements are so ok for the maintainers.
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
Most usage of JError are the raise* functions. What you think about the replacement messages?
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-07 13:27:20 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_Date | 2017-07-07 13:27:20 | ⇒ | 2017-07-07 13:27:21 |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/16952
closed as having PR #17013
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16952.
This one should stay open. It is for version 3 which improves the deprecated messages.
| Status | Closed | ⇒ | Pending |
| Closed_Date | 2017-07-07 13:27:21 | ⇒ | |
| Closed_By | joomla-cms-bot | ⇒ |
Set to "open" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/16952
reopened, thanks for Hint, @laoneo
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16952.
Any plan with this one?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-08-10 12:20:23 |
| Closed_By | ⇒ | mbabker |
FWIW it's not just removing
JErrorthat needs to be done.JObjecthas some tight integrations with it that would need to be addressed as well. That affects the MVC layer (plusJTable) at a minimum (I forget which API libraries are still extendingJObjecttoo).So? on working on phasing it out. Just keep in mind it's probably not going to be as simple as changing
JError::raiseError()tothrow new FooException.