[#16945] - Add filter by Tag to mod_article_category
- Fixed in Code Base
- 29 Jul 2017
- Medium
- Build: staging
- Easy Test
- # 16945
- Diff
- hans2103:staging
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
Pull Request for missing feature
Summary of Changes
This Pull Request add the option to filter by tag.
- When you create a menu item for Category Blog you can select both Category and Tag.
- When you create the module mod_article_category you cannot filter by Tag.
This pull request adds the ability to filter by tag too.
Testing Instructions
- Have com_content items with tags
- Create a module mod_article_category
-
- assign to a visible module position
-
- select category to filter the content
-
- show X amount of items to display
-
- select tag to filter... oh boy... there is no tag filter
apply patch
- Refresh backend
- Open created module
-
- select tag to filter... yes... there is the option to filter by tag
Expected result
Before patch
- Refresh frontend and notice X amount of items from a selected category.
After patch
- Refresh frontend and notice X amount of items from a selected category and filtered by tag
Documentation Changes Required
Be sure you have content items with tags assigned to them.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16945.
| Status | Pending | ⇒ | Ready to Commit |
| Easy | No | ⇒ | Yes |
RTC after two successful tests.
| Labels |
Added:
?
|
||
I fixed the codestlye issues
@brianteeman should we test again or set RTC?
it was only codestyle so one more test will be fine but it shouldnt have been set to rtc with those errors
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16945.
RTC.
infograf768
- | Milestone |
Added: |
||
rdeutz
- | Milestone |
Added: |
||
| Milestone |
Removed: |
||
Looks fine, if someone can do a quick test with the added logic in place we should be good to merge this.
will test now.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16945.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16945.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-29 14:59:33 |
| Closed_By | ⇒ | mbabker |
@pepperstreet please create a new pull request. This one has already been merged and closed.
I have tested this item✅ successfully on eadf35a
I tested this extra option successfully, nice to have this option, Thanks Hans
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16945.