[#16935] - Make the core user plugin optional
- Fixed in Code Base
- 5 Jul 2017
- Medium
- Build: staging
- # 16935
- Diff
- zero-24:UsersModelUser
- Success hound No violations found. Woof! Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #16921
Summary of Changes
In case that the plugin is not enabled there is a notice on the screen.
Testing Instructions
set error reporting to maximum
disable the joomla user plugin (User - Joomla)
Expected result
No error and the password field is required
Actual result
a php notice
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16935.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16935.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
Is it not the expected behaviour?
it is stated in the plugin "Warning! You must have enabled at least one plugin that handles the user session management or you will lose all access to your site."
so the question really is - does this notice appear if you disable the core user plugin and enable a different one?
does this notice appear if you disable the core user plugin and enable a different one?
Yes.
does this notice appear if you disable the core user plugin and enable a different one?
Yes.
thats ok then - just wanted to check
This really solves the issue, that I had reported in closed issue #16921. It doesn't make sense that an extension must be enabled before another extension can read a param of the first extension. Makes me happy. Does RTC mean it will be implemented? Sorry if asking the obvious...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16935.
@franz-wohlkoenig what does RTC stand for?
551f798 successfully tested, BUT Dreamweaver cs5.5 nows throws error on line 251 (earlier line 246)
line 251 was line 246: $stillSuperAdmin = ($stillSuperAdmin) ? ($stillSuperAdmin) : JAccess::checkGroup($group, 'core.admin');
line 251 now is: $stillSuperAdmin = $stillSuperAdmin ?: JAccess::checkGroup($group, 'core.admin');
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16935.
RTC = Ready to Commit
This is an issue with your version of Dreamweaver not recognizing the ?: operator. I am using Dreamweaver CS6.0 and I don't get an error with that line.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-05 17:47:59 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 3aa6bfb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16935.