[#16933] - Don't add the field when it is set to hidden
- Fixed in Code Base
- 11 Jul 2017
- Medium
- Build: staging
- # 16933
- Diff
- zero-24:empty_captcha
User tests: Successful: Unsuccessful:
Pull Request for Issue #16887
Summary of Changes
When the field is set to hidden we don't push it as available field
Testing Instructions
Go to the Forgot your username? or Forgot your password? view with and without the recatcha plugin enabled
Expected result
Works with and without the plugin enabled.
Without the plugin enabled see:
Actual result
Documentation Changes Required
none
Additional Infos
@mbabker i have requested a review as I'm not sure if this is the correct way to do that. Should the view be resposible to hide the hidden fields or is the underlaying code responsible to do that?
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Ok so we should better move the hidden check to the views?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16933.
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Front End com_users |
I have just moved the check to the view please retest.
Looks better now.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16933.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16933.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-11 14:02:12 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
Something about this doesn't seem correct just on a glance. Hidden fields should always be available, the logic to determine if they print any markup needs to be closer to the rendering spot though, not at a high level in the main form class.