? Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
1 Jul 2017

Namespaces the punicode class and is deprecating the wrappers. The classmap helper section got reordered to be inline with the filesystem.

avatar laoneo laoneo - open - 1 Jul 2017
avatar laoneo laoneo - change - 1 Jul 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Jul 2017
Category Libraries
avatar mbabker
mbabker - comment - 1 Jul 2017

I don't see why this is moving to the helper namespace instead of staying in a string namespace, other than that seems fine.

avatar laoneo
laoneo - comment - 2 Jul 2017

For me it looks like one of this gazillion helper classes we have in core which has only static functions. That's why I put it into the helper folder.

avatar wilsonge
wilsonge - comment - 2 Jul 2017

All of String is static. I'm with Michael on this - it belongs with the string package

avatar laoneo laoneo - change - 2 Jul 2017
Labels Added: ?
avatar laoneo
laoneo - comment - 2 Jul 2017

Done.

avatar mbabker mbabker - change - 2 Jul 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-07-02 15:48:22
Closed_By mbabker
avatar mbabker mbabker - close - 2 Jul 2017
avatar mbabker mbabker - merge - 2 Jul 2017

Add a Comment

Login with GitHub to post a comment