?
avatar ggppdk
ggppdk
29 Jun 2017

Steps to reproduce the issue

Changes made by that PR #13257 , do not check the exact type of the "callable"
it just blindly assumed that it is a variable method name

It breaks exception handling in J3.7.3 RC2 (changes in redirect plugin)
and also other changes may cause failures in the future if a other callable cases are used

Throw an exception in backend,
e.g. a PHP syntax error
and see that redirect plugin fails to call the previous exception handler

Expected result

Exceptions can be handled in backend

Actual result

Exception handling does not work in backend

System information (as much as possible)

J3.7.3 RC2

Additional comments

This is a release blocker, we no longer having exception handling usable in backend

avatar ggppdk ggppdk - open - 29 Jun 2017
avatar joomla-cms-bot joomla-cms-bot - change - 29 Jun 2017
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 29 Jun 2017
avatar ggppdk
ggppdk - comment - 29 Jun 2017

Printing the previous exception handler, used here:
https://github.com/joomla/joomla-cms/blob/staging/plugins/system/redirect/redirect.php#L112

print_r(self::$previousExceptionHandler);

i get
Array ( [0] => JErrorPage [1] => render )

so it can not be called like:
self::$previousExceptionHandler($error);

avatar ggppdk ggppdk - change - 29 Jun 2017
Title
Please revert PR #13257, exception handling broken in J3.7.3 RC2
Regression, exception handling broken in J3.7.3 RC2
avatar ggppdk ggppdk - edited - 29 Jun 2017
avatar zero-24
zero-24 - comment - 29 Jun 2017

@rdeutz @frankmayer can you take a look here?

avatar frankmayer
frankmayer - comment - 29 Jun 2017

On it.

avatar ggppdk ggppdk - change - 29 Jun 2017
The description was changed
avatar ggppdk ggppdk - edited - 29 Jun 2017
avatar ggppdk ggppdk - change - 29 Jun 2017
The description was changed
avatar ggppdk ggppdk - edited - 29 Jun 2017
avatar ggppdk ggppdk - change - 29 Jun 2017
The description was changed
avatar ggppdk ggppdk - edited - 29 Jun 2017
avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Jun 2017
Status New Information Required
avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Jun 2017
Category Administration
avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Jun 2017
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2017-06-30 04:28:52
Closed_By franz-wohlkoenig
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jun 2017
Closed_By franz-wohlkoenig joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 30 Jun 2017
avatar joomla-cms-bot
joomla-cms-bot - comment - 30 Jun 2017
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 30 Jun 2017

closed as havin PR #16913


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16912.

Add a Comment

Login with GitHub to post a comment