[#16887] - Don't output markup when captcha is disabled
- Closed
- 1 Jul 2017
- Medium
- Build: staging
- # 16887
Steps to reproduce the issue
On frontend, click Forgot your username? and Forgot your password?.
There is a large gap between Email Address and Submit button.
View page source to see markup for captcha even though captcha is disabled.
Expected result
No markup for captcha.
Actual result
<div class="control-group">
<div class="control-label">
</div>
<div class="controls">
</div>
</div>
System information (as much as possible)
3.7.3-nightly build
protostar template
Additional comments
| Labels |
Added:
?
|
||
| Category | ⇒ | Authentication Code style |
Comes from here: https://github.com/joomla/joomla-cms/blob/staging/components/com_users/views/remind/tmpl/default.php and https://github.com/joomla/joomla-cms/blob/staging/components/com_users/views/reset/tmpl/default.php
It looks like we need to add a check there if nothin is returned or similiar.
Or better qould be that the field is not returned using that method but this needs to be debugged.
yes I saw that BUT doesnt that if statement get the code for the remind/reset input field so I dont see why it is being run again for the captcha
https://github.com/joomla/joomla-cms/blob/staging/components/com_users/models/forms/remind.xml
The view has the captcha field so it looks like it is also returned but as empty field. But i hope i can find some time to debug that and see why the method returned empty fields.
AH now I understand the why :)
| Status | New | ⇒ | Discussion |
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-01 14:45:53 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Closed_By | franz-wohlkoenig | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/16887
closed as having PR #16933
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16887.
I can confirm this behaviour but it makes no sense to me why it happens