[#16856] - hiddenFieldsets & configFieldsets needs to be defined
- Fixed in Code Base
- 12 May 2018
- Medium
- Build: staging
- # 16856
- Diff
- zero-24:$hiddenFieldsets
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #16854
Summary of Changes
hiddenFieldsets & configFieldsets needs to be defined in any case
Testing Instructions
<?php $this->set('show_options', 0) ?>
<?php echo JLayoutHelper::render('joomla.edit.params', $this); ?>Expected result
No error
Actual result
see #16854
Documentation Changes Required
none
please test @asika32764
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
?
|
||
pushed
Fixed
@asika32764 Please mark your test result as success by using the "Test this" button here: https://issues.joomla.org/tracker/joomla-cms/16856
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16856.
altered test successfully by @asika32764 in Issue Tracker.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16856.
Would be great to get another tester here?
How did you tested it?
Testing Instructions
Place this code
<?php $this->set('ignore_fieldsets', false); ?>
<?php $this->set('show_options', 0) ?>
<?php echo JLayoutHelper::render('joomla.edit.params', $this); ?>enable the debugger and set a break point here:
https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/edit/params.php#L57
Run the code (login and try to edit an article).
Notice that the variable $hiddenFieldsets is not instanciated.
apply this patch
try again
This does not throw a hard error but it is a bug that this patch is going to fix ;)
i tested it from the limited information available in the initial post. still not clear if this is frontend or backend or both
This issue is at the backend edit page if we use custom fields. It will not shows fatal error but notice message if we set error_reporting to development.
I have tested this item
Open \components\com_content\views\form\tmpl\edit.php
Add <?php $this->set('show_options', 0); ?> on line 102.
Edit an article on the frontend.
Without PR:
Notice: Undefined variable: hiddenFieldsets in \layouts\joomla\edit\params.php on line 57
Warning: in_array() expects parameter 2 to be array, null given in \layouts\joomla\edit\params.php on line 57
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16856.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16856.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-12 17:23:34 |
| Closed_By | ⇒ | mbabker | |
| Labels |
Added:
?
|
||
Another error message if we didn't set
hiddenFieldsetsin view.Maybe use this?
$hiddenFieldsets = $displayData->get('hiddenFieldsets') ?: array();Or
!empty($displayData->hiddenFieldsets) ? $displayData->hiddenFieldsets : array()