[#16852] - Improve menu main fix
- Fixed in Code Base
- 30 Jun 2017
- Medium
- Build: staging
- # 16852
- Diff
- richard67:improve-menu-main-fix
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Pull Request for no issue.
Summary of Changes
This Pull Request (PR) improves the already merged PR #16577 as discussed there with @rdeutz .
- Delete the obsolete menu types and not rename them to ".._to_be_deleted".
- On renaming the "menu" menu type, use a new name which is more likely not already being used by a user-defined menu type. The new name is "main_is_reserved_133C585", with "133C585" being the hex value of "20170117", which is the date part of the schema update scripts' names. This should be crazy enough for not being used yet.
Testing Instructions
Code review.
Expected result
New name of menu type "main" is "main_is_reserved_133C585".
Obsolete menu type records "main" or "menu" for admin menu are deleted.
Actual result
New name of menu type "main" is "main_is_reserved".
Obsolete menu type records "main" or "menu" for admin menu are renamed to "..._to_be_deleted".
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql MS SQL |
| Labels |
Added:
?
|
||
@alikon @Quy In the mood for an easy test by review?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16852.
@rdeutz I noticed that this PR did not make it into RC2. Does it really need to be tested, and if so, is it enough to do code review? It contains the changes we discussed with PR #16577 , and if it will not go into 3.7.3 it will not make much sense or it has to be added a new schema update for update from 3.7.3 to 3.7.4 then. After our discussion in PR #16577 I thought it will be sufficient if you review it.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16852.
My fault, sorry, going to merge it into the stable release next week
| Milestone |
Added: |
||
Ok, thanks. Let me know if something is missing, e.g. if you want it to be tested.
| Status | Pending | ⇒ | Ready to Commit |
| Milestone |
Removed: |
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16852.
infograf768
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-30 05:28:13 |
| Closed_By | ⇒ | rdeutz |
@rdeutz I did it now in a static way and not using the count as I discussed with you, because also using the count is not safe e.g. if someone has crazy menu type names "main_is_reserved_" with numbers at the end (which would be close to sabotage from my point of view). I think now the new name is strange enough for not being used yet.