? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
24 Jun 2017

Delete a default template style (set to ALL or to a specific language)

One gets correctly the Error message in the manager but we get in the PHP logs

PHP Notice: Use of undefined constant SOME_ERROR_NUMBER - assumed 'SOME_ERROR_NUMBER etc.

Changed SOME_ERROR_NUMBER to 500.

Test again after patch

Simple one that can go in 3.7.3
@rdeutz

avatar infograf768 infograf768 - open - 24 Jun 2017
avatar infograf768 infograf768 - change - 24 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jun 2017
Category Administration com_templates
avatar brianteeman
brianteeman - comment - 24 Jun 2017

Is this change not just masking an issue as presumably it used to work

On 24 Jun 2017 10:18 am, "infograf768" notifications@github.com wrote:

Delete a default template style (set to ALL or to a specific language)
Look at PHP logs:
PHP Notice: Use of undefined constant SOME_ERROR_NUMBER - assumed
'SOME_ERROR_NUMBER etc.

Changed SOME_ERROR_NUMBER to 500.

Test again after patch

Simple one that can go in 3.7.3
@rdeutz https://github.com/rdeutz

You can view, comment on, or merge this pull request online at:

#16843
Commit Summary

  • Fix : Correcting Template style delete Notice

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#16843, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bYiF6wW0CdGiSgbQyPWtW_cbhn2ks5sHMZSgaJpZM4OEQ3B
.

avatar infograf768
infograf768 - comment - 24 Jun 2017

It DOES work. I guess seomeone was hesitating between a 403 and a 500 as both are found in core, the majority being a 500.

avatar infograf768 infograf768 - change - 24 Jun 2017
The description was changed
avatar infograf768 infograf768 - edited - 24 Jun 2017
avatar infograf768
infograf768 - comment - 24 Jun 2017
avatar wilsonge wilsonge - change - 24 Jun 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-24 16:54:26
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 24 Jun 2017
avatar wilsonge wilsonge - merge - 24 Jun 2017

Add a Comment

Login with GitHub to post a comment