? Pending

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
23 Jun 2017

Pull Request for Improvement.

Summary of Changes

In 4.0 Atum template it's getting JDocument as $doc when we already have $this that is a JDocumentHtml.
So remove those and replace with $this.

Testing Instructions

Mainly code review.
But to test:

  • Use 4.0 latest
  • Apply patch
  • Atum administrator template works as usual.

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 23 Jun 2017
avatar andrepereiradasilva andrepereiradasilva - change - 23 Jun 2017
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jun 2017
Category Administration Templates (admin)
avatar andrepereiradasilva andrepereiradasilva - change - 23 Jun 2017
Title
[4.0] Atum: Calling JDocument in tempalte files is not needed
[4.0] Atum: Calling JDocument in template files is not needed
avatar andrepereiradasilva andrepereiradasilva - edited - 23 Jun 2017
avatar wilsonge wilsonge - change - 23 Jun 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-23 11:10:24
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 23 Jun 2017
avatar wilsonge wilsonge - merge - 23 Jun 2017
avatar wilsonge
wilsonge - comment - 23 Jun 2017

Thankyou :)

Add a Comment

Login with GitHub to post a comment