Feeling Lucky
?
[#16832] - [4.0] Templates are already html5 (default), so remove unused setHtml5 code
- Fixed in Code Base
- 23 Jun 2017
- Medium
- Build: 4.0-dev
- # 16832
- Diff
- andrepereiradasilva:html5-as-default
- Success hound No violations found. Woof! Details
User tests: Successful: Unsuccessful:
Pull Request for Improvement.
Summary of Changes
Small change.
In 4.0 html5 is the default rendering engine (see https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/joomla/document/html.php#L101) so default templates don't need to set them as html5.
Remove that code from the the remaning template files (component and offline template files) and installation index.php.
Testing Instructions
Mainly code review, but you can test as this:
- Apply patch
- Component (ex: article e-mail button) and offline (site offline) site/admin templates render as before.
- Installation template render as before.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Installation Front End Templates (site) |
franz-wohlkoenig
- | Title |
|
||||||
wilsonge
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-23 10:37:18 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
there is a failure in appveyor that doesn't seem related to this