[#16823] - Remove unused join from categoredit, greatly hindering performance when having large number of categories
- Fixed in Code Base
- 5 Jul 2017
- Medium
- Build: staging
- # 16823
- Diff
- ggppdk:patch-34
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #8884
Summary of Changes
Performance changes to allow categoryedit to scale well when number of category increases
- Remove a useless join from the categoryedit form field, used forms:
banner form, category form, contact form, newsfeed form, article form (Backend / Frontend) - Remove DISTINCT (duplicates were created because of the above removed JOIN)
- Merge sub-query with SELF to main query
Probably this join (1) originates from some code that was copied, or it was used by some code that is no longer present in categoryedit form field
Why its existense is useless , please read my explanation here:
#8884 (comment)
Also for worries of this join being used to remove child categories in category-edit form
so that you can not set a parent category to be under one of its childs !
The answer is that it is another join, please see my other comment here:
#8884 (comment)
Testing Instructions
- the queries of the categoryedit should not produce query error on
all forms that the field is used:
banner form, category form, contact form, newsfeed form, article form (Backend / Frontend) - and categories displayed inside the category select should not be different
administrator/components/com_banners/models/forms/banner.xml(36): type="categoryedit"
administrator/components/com_categories/models/forms/category.xml(34): type="categoryedit"
administrator/components/com_contact/models/forms/contact.xml(73): type="categoryedit"
administrator/components/com_content/models/forms/article.xml(77): type="categoryedit"
administrator/components/com_newsfeeds/models/forms/newsfeed.xml(52): type="categoryedit"
components/com_content/models/forms/article.xml(93): type="categoryedit"
Expected result
Performance of categoryedit field scales with the number of categories e.g. 5000
Actual result
Performance of categoryedit field does not scales with number of categories
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories |
It is good, I think you could replace subquery by regular query, and remove distinct.
Yes, after the removal of the unused join
- the DISTINCT seems to be no longer needed (need to check more carefully)
- also yes the subquery can be merged with the main query ... (need to check this too more carefully)
| Labels |
Added:
?
|
||
Ok besides the not used JOIN, I have
- removed DISTINCT (duplicates were created because of the now removed JOIN, so no longer needed),
- merged subquery to parent query
i did a little testing, it should be correct
just now i am not 100% sure of it
I have tested this item
+ code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16823.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16823.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
rdeutz
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-05 16:23:32 |
| Closed_By | ⇒ | rdeutz |
It is good, I think you could replace subquery by regular query, and remove distinct.