[#16813] - [4.0] Trying to fix AppVeyor failure
- Closed
- 22 Jun 2017
- Medium
- Build: 4.0-dev
- # 16813
- Diff
- Bakual:AppVeyor
- Pending hound Hound is busy reviewing changes... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #16698 (at least part of it).
AppVeyor currently shows 17 errors and 1 failure. This PR only addresses the single failure..
Summary of Changes
Removes the realpath call from the test. Reason is that the paths are stored in JForm with mixed dividers, eg the stored default path we check looks like this on Windows: "D:\xampp\htdocs\joomla4\libraries/joomla/form/fields". Realpath however will change the expected path to "D:\xampp\htdocs\joomla4\libraries\joomla\form/fields" and thus the in_array() check fails.
Testing Instructions
I guess if AppVeyor (17 errors remain, but the fail is gone) and Travis passes, then this is fine.
Lets see what the tests say.
Expected result
No failurs in AppVeyor
Actual result
One failur in AppVeyor
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
-
Why we have a test validating default paths are getting arbitrarily loaded by a call to these methods beats the crap out of me.
-
The tests were broken anyway because the default load paths were changed. The correct paths are loaded from outside that method (as it should be). The new paths are autoloaded class paths hence there's no need to either arbitrarily load the new paths or validate that default paths are included when calling that method.
Ah, wasn't aware you removed them in J3.8.
Then this should just be merged up and I can close this PR.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-22 14:05:41 |
| Closed_By | ⇒ | Bakual | |
| Labels |
Added:
?
?
|
||
If we want to keep the tests, then this pr including restore of the tests should be done against the 3.8 branch as the tests got removed by @mbabker in d21343e there.