? ? Pending

User tests: Successful: Unsuccessful:

avatar imanickam
imanickam
21 Jun 2017

The current Austrian flag (de_at.gif) is a Service/State flag used in the Government buildings and officials. The Civilian flag does not the insignia in the middle. So, a new flag image has to be used in the place of the current Flag.

Pull Request for Issue # .

Summary of Changes

Basis of change:
Forum Post - https://forum.joomla.org/viewtopic.php?f=711&t=952006

Content of the post:

Hi Joomla! team!

Thank you for the multi language module!
In order to help improving Joomla! I want to inform you, that the flag icon for Austria (de_at.gif) is not correct:
According to Austrian laws the flag having the eagle crest on it may be used by i.e. governmental institutions only (see §4 in [url]https://www.ris.bka.gv.at/GeltendeFassung.wxe?Abfrage=Bundesnormen&Gesetzesnummer=10000782[/url]).
Instead you should use the national flag of Austria without the crest on it; this may be used by anyone else.
Here is an example:
https://de.wikipedia.org/wiki/Flagge_%C3%96sterreichs#/media/File:Flag_of_Austria.svg
According to the Federal Ministry of Defense the color for the red parts of the flag shall be:
http://encycolorpedia.com/ed2e38
More important information about the use and look of the Austrian flag you can find here (in German):
http://www.laenderservice.de/flaggen/europa/oesterreich.aspx

Please consider this in your next Joomla! update - thank you!

Kind regards,
Gerald

Based on the contents in the links provided, the Civilian flag has to be used in the place of Service Flag.

Testing Instructions

Expected result

The current Austrian Flag image file (de-at.gif) will be removed and its place the revised Austrian Flag image file will be added.

Actual result

Documentation Changes Required

avatar imanickam imanickam - open - 21 Jun 2017
avatar imanickam imanickam - change - 21 Jun 2017
Status New Pending
avatar brianteeman
brianteeman - comment - 21 Jun 2017

Why are you not replacing it now in this pr?

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 21 Jun 2017 - Tested unsuccessfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Jun 2017

I have tested this item ? unsuccessfully on 15b2b1e

Flag is same as before.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16800.

avatar imanickam
imanickam - comment - 21 Jun 2017

When I tried to upload a file, I got the message that my permissions does not allow uploading. Following is the message I got when I tried to upload the revised image file:

Uploads are disabled.
File uploads require push access to this repository.

So, I thought of deleting the existing file and adding the revised image file (attached) subsequently.
de_at

avatar brianteeman
brianteeman - comment - 21 Jun 2017

That's because you are using the github web site to try an upload an image to Joomla which correctly you don't have permission to do.

Simply go the Joomla repo in your own account, select this branch (patch-4) and you can upload the image and it will automatically update this.

avatar brianteeman
brianteeman - comment - 21 Jun 2017

@franz-wohlkoenig patch tester will not delete files

avatar mbabker
mbabker - comment - 21 Jun 2017

@franz-wohlkoenig patch tester will not delete files

More specifically, binary file support in patch tester is experimental at best. It just has more quirks compared to handling plain text files.

avatar brianteeman
brianteeman - comment - 21 Jun 2017

I was keeping it simple :)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Jun 2017

@brianteeman i thought PR changes Flags.

avatar imanickam imanickam - change - 21 Jun 2017
Labels Added: ?
avatar imanickam imanickam - change - 21 Jun 2017
Title
Deletion of Austrian Flag to be Replaced Subsequently
Replacement of Austrian Flag
avatar imanickam imanickam - edited - 21 Jun 2017
avatar brianteeman brianteeman - test_item - 21 Jun 2017 - Tested successfully
avatar brianteeman
brianteeman - comment - 21 Jun 2017

I have tested this item successfully on f862d11


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16800.

avatar imanickam imanickam - change - 21 Jun 2017
The description was changed
avatar imanickam imanickam - edited - 21 Jun 2017
avatar brianteeman
brianteeman - comment - 21 Jun 2017

@franz-wohlkoenig it didn't but it does now :)

avatar imanickam
imanickam - comment - 21 Jun 2017

Thanks Brian for the guidance. I have done the changes accordingly.

avatar franz-wohlkoenig franz-wohlkoenig - test_item - 21 Jun 2017 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Jun 2017

I have tested this item successfully on f862d11


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16800.

avatar franz-wohlkoenig franz-wohlkoenig - change - 21 Jun 2017
Status Pending Ready to Commit
Easy No Yes
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 21 Jun 2017

RTC after two successful tests.

avatar infograf768
infograf768 - comment - 21 Jun 2017

@rdeutz
can we get that into 3.7.3?

avatar rdeutz rdeutz - change - 21 Jun 2017
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-06-21 18:19:12
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 21 Jun 2017
avatar rdeutz rdeutz - merge - 21 Jun 2017

Add a Comment

Login with GitHub to post a comment