[#16787] - [doc block] - fix wrong doc block for getTableKeys()
- Fixed in Code Base
- 9 Jul 2017
- Medium
- Build: staging
- # 16787
- Diff
- alikon:patch-92
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
the getTableKeys() retrieve indexes information about one table and not from a list of table names
https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/database/driver/mysqli.php#L477
$this->setQuery('SHOW KEYS FROM ' . $this->quoteName($table));
Summary of Changes
fixed wrong doc block for getTableKeys()
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
should not, otherwise the unit test should complain
https://github.com/joomla/joomla-cms/blob/16d5a298cfecc38484c42993069401fab088d789/tests/unit/suites/database/driver/mysqli/JDatabaseDriverMysqliTest.php#L352
public function testGetTableKeys()
{
$this->assertThat(
self::$driver->getTableKeys('#__dbtest'),
$this->isType('array'),
'The list of keys for the table is returned in an array.'
);
}
line 1285 is changing the code from tables to table
i've just put a more precise parameter name, no side-effect on invoking that method
I have tested this item
Code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16787.
I have tested this item
The docblock now matches the code.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16787.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-07-09 21:32:13 |
| Closed_By | ⇒ | zero-24 |
Merged thanks
This is changing more than just the docblock?