[#16783] - Fix for menu item type change
- Fixed in Code Base
- 21 Jun 2017
- Medium
- Build: staging
- # 16783
- Diff
- tonypartridge:patch-1
User tests: Successful: Unsuccessful:
Pull for #16719 and closing of #16735. When changing menu items from say a blog to a single article, it would not show all available options i.e. select article. This was caused by my PR #16486 so I have relaxed the conditioning which allows this to work again, and whilst having two menu items open refreshing the page loads on the menu item details they are on. The only downside here, is if you have two tabs open and one tab is a new menu item it will load in the other tabs details if a change was made when you refresh the page. A very rare scenario which I believe can be overlooked at this point.
Please test.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
I have tested this item
Unfortunately, this didn't do the trick for me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16783.
| Labels |
Added:
?
|
||
Sorry guys, it was a tired day. I missed off a change doing it via github.com (local repo needs sorting). Please re-test with the above.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16783.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16783.
| Status | Pending | ⇒ | Ready to Commit |
RTC
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-21 05:55:53 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item? unsuccessfully on bf5ca70
Applied PR, create new Menu Type "Blog", got:
Without PR:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16783.