[#16779] - [4.0] Move toolbar button ID'd to buttons themselves
- Fixed in Code Base
- 21 Jun 2017
- Medium
- Build: 4.0-dev
- # 16779
- Diff
- C-Lodder:toolbar-fix-2
User tests: Successful: Unsuccessful:
This PR fixes the issue mentioned here #16763
I've reverted the previous PR (#16749) I did that adds a div wrapper for each button and the ID is now added on the button itself.
Both list and edit views seem to work.
@infograf768 - You mentioned something about com_associations using JS to target these ID's. Would you mind testing please and let me know.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Libraries |
| Labels |
Added:
?
|
||
Buttons in com_content are now fixed.
Com_associations seems to work. The toolbar buttons disappear as soon as you have selected a type and language. Same as in J3.
Not sure I can replicate this. Would you be able to capture a GIF for me to see?
My comment was unclear. Everything works from what I see
ah fair enough, thanks for testing
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16779.
@franz-wohlkoenig Didi it myself now, but thanks for the reminder
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-21 11:33:17 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
If I open the save button now (to show the other save options), the button "jumps" (enlarge a bit), was this also before this patch or was this introduced via this patch?
Doesn't do that for me, using Chrome.
If it does for you, can you open a new issue with browser versions and the like?
@bembelimen what browser are you experiencing that on? Try clearing your cache if you havent already
I get
Notice: Undefined index: id in ...\layouts\joomla\toolbar\versions.php on line 31